Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Few small test fixes #30

Merged
merged 2 commits into from

3 participants

@pkrefta

Hi guys,

I tried Filatiron and it turned out that two tests didn't pass - both required to add index.js because I've encoutered "Cannot find module" message. I've also removed console.log from one of the because it waa whole request object into console.

@jfhbrook

Which tests weren't passing? I want to understand why we need these index.js files.

@pkrefta

Sorry for alarm - I didn't noticed that tests have passed despite this two errors - vows sad 2 errored. These messages were generated by ecstatic-test.js when I was whole test suite with vows test/* -i - howewer running only this test doesn't raise any errors.

@pksunkara pksunkara merged commit f771e13 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
1  test/after-test.js
@@ -8,7 +8,6 @@ function stream_callback(cb) {
var stream = new union.ResponseStream();
stream.once("pipe", function (req) {
- console.log(req);
return cb ? cb(null,req) : undefined;
});
View
0  test/fixtures/index.js
No changes.
View
0  test/helpers/index.js
No changes.
Something went wrong with that request. Please try again.