Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Sessions are not saved when using Connect.session() middleware. #39

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

travist commented Sep 16, 2012

I am working on getting FlatIron to play nicely with Passport.js with https://github.com/travist/flatiron-passport.

I noticed that the session saving fails with OAuth because https://github.com/senchalabs/connect/blob/master/lib/middleware/session.js#L274 tries to inject itself before the end method is called. However this is attached to the this pointer of the request object and not this.res.

This can all be fixed if we just check to see if the end method is attached to this, and call it instead if it is... If not, then fallback to current behavior.

Contributor

pksunkara commented Sep 16, 2012

I will look into this soon. Thanks.

Contributor

pksunkara commented Nov 12, 2012

@travist Can you post an example so that I can test this?

Sorry for the delay.

Owner

indexzero commented Nov 12, 2012

This is a bug in the original implementation of redirect. It has been fixed in HEAD

@indexzero indexzero closed this Nov 12, 2012

As of Union version 0.3.5 res is renamed response like so:
this.response.end();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment