[fix] Be more defensive when working with query methods from Transp…

…orts. Fixes #356.
winstonjs · Sep 24, 2014 · cf27437 · cf27437
1 parent eaebaa9
commit cf27437
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/lib/winston/logger.js b/lib/winston/logger.js
@@ -252,11 +252,20 @@ Logger.prototype.query = function (options, callback) {
   //
   function addResults (transport, next) {
     queryTransport(transport, function (err, result) {
-      result = err || result;
-      if (result) {
-        results[transport.name] = result;
+      //
+      // queryTransport could potentially invoke the callback
+      // multiple times since Transport code can be unpredictable.
+      //
+      if (next) {
+        result = err || result;
+        if (result) {
+          results[transport.name] = result;
+        }
+
+        next();
       }
-      next();
+
+      next = null;
     });
   }