Skip to content

RTL Support#120

Closed
yeganemehr wants to merge 1 commit into
flatlogic:masterfrom
yeganemehr:master
Closed

RTL Support#120
yeganemehr wants to merge 1 commit into
flatlogic:masterfrom
yeganemehr:master

Conversation

@yeganemehr

@yeganemehr yeganemehr commented Apr 10, 2017

Copy link
Copy Markdown

RTL support by adding rtl class to <body> or <html>

@DimaSavchenko

DimaSavchenko commented May 19, 2017

Copy link
Copy Markdown
Contributor

Hi @yeganemehr !
I have tried your solution and it look no quite well:

image

@yeganemehr

yeganemehr commented May 20, 2017 •
edited
Loading

Copy link
Copy Markdown
Author

Hi @DimaSavchenko
Actually It's looks good, but you did not feel that way because you tested in a left-to-right language (English) and It's looks strange to you, also you did not add style="direction:rtl" to your body.
Let's try it in Persian demo page:
awesome bootstrap checkbox demo

And finally let's mix my Persian demo page with bootstrap-rtl and see the result:
awesome bootstrap checkbox demo-rtl

@KillerSquid

KillerSquid commented Jun 23, 2017

Copy link
Copy Markdown

For my money JTCE's solution is way better. Pure CSS and like 5 seconds to apply:
#115

@yeganemehr

yeganemehr commented Jun 25, 2017

Copy link
Copy Markdown
Author

OK @KillerSquid but did you ever develop one RTL page? I guess not!
adding rtl class for every checkbox in page is not cool at all.

@KillerSquid

KillerSquid commented Jun 26, 2017

Copy link
Copy Markdown

But being able to selectively apply it to ONLY the checkboxes where you need RTL support is more functionally sound than a blanket 'all page' approach. Plus you can always just roll it into the existing CSS for all the checkboxes if you don't want to go through the hassle of typing three letters or programatically apply it to all checkboxes at runtime.
Also- there's absolutely no need to get snippy. This is an open forum and people are allowed to post their ideas and opinions on software suggestions. What works for you may not (and in my case, DID NOT) work for everyone so offering other suggestions on ways to achieve your goals is the WHOLE POINT OF GITHUB.

@cecilian

cecilian commented Mar 30, 2021

Copy link
Copy Markdown

Hello all,
is there any chance to see this merged in the not-so-far future?
Sure we can all patch the scss in our own projects to support RTL and it's not a big deal but it's a bit lame because we lose in terms of compatibility.

Also I agree with @yeganemehr that the "blanket" approach (styling applied to all elements of the page if the direction is RTL) works better especially if the plugin is being used in a multilingual site (so the same page can be served with different layouts).

This is a great plugin and it would be so helpful for it to support RTL out of the box.
Thank you!

@Blari Blari closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yeganemehr @DimaSavchenko @KillerSquid @cecilian @Blari