Fix input inside label #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package requires that the checkbox/radio inputs need to be positioned outside of the label. That's fine (and unavoidable).
However currently if some checkbox/radio is inside of label for whatever reason, it breaks. And this can actually be avoided.
In my case I use 2 different libraries to generate forms. One of them is legacy and is unable to render checkbox outside of label which is why I need to fix this.
This pull request only updates the CSS file. The same changes needs to be done in the LESS and SCSS files as well. Or is there a way to update just one of them and generate the others somehow?