New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git downloads with --disable-updates #98

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@alexlarsson
Member

alexlarsson commented Jan 11, 2018

We regressed in --disable-updates in for git sources, as they were always downloaded, as per #97

This fixes that, and also makes intial download a bit more robust by using a temporary destination.

alexlarsson added some commits Jan 11, 2018

Fix --disable-updates for git sources
We lost the ability to not update if a git repo was already checked out.
This fixes that again.
git: When mirroring a new repo, use a temporary destination
This way, if anything fails during the initial pull we can remove it
and not be confused by a partial repo on the next run.
@chergert

This comment has been minimized.

Contributor

chergert commented Jan 11, 2018

Seems to work for me, and code looks good.

@alexlarsson

This comment has been minimized.

Member

alexlarsson commented Jan 11, 2018

@rh-atomic-bot

This comment has been minimized.

Collaborator

rh-atomic-bot commented Jan 11, 2018

📌 Commit 3b5dd3b has been approved by alexlarsson

@rh-atomic-bot

This comment has been minimized.

Collaborator

rh-atomic-bot commented Jan 11, 2018

⚡️ Test exempted: pull fully rebased and already tested.

rh-atomic-bot added a commit that referenced this pull request Jan 11, 2018

Add flatpak_file_rename
Closes: #98
Approved by: alexlarsson

rh-atomic-bot added a commit that referenced this pull request Jan 11, 2018

git: When mirroring a new repo, use a temporary destination
This way, if anything fails during the initial pull we can remove it
and not be confused by a partial repo on the next run.

Closes: #98
Approved by: alexlarsson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment