Command name #13
Merged
Command name #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2018 09:10
The command is called flatpak-spawn, not flatpak-portal-spawn.
Take out the misleading name and say what we do.
TingPing
reviewed
Dec 16, 2018
| @@ -263,7 +263,7 @@ main (int argc, | |||
|
|
|||
| context = g_option_context_new ("COMMAND [ARGUMENT…]"); | |||
|
|
|||
| g_option_context_set_summary (context, "Flatpak portal spawn"); | |||
| g_option_context_set_summary (context, "Run a command in a sandbox"); | |||
There was a problem hiding this comment.
Well, sometimes not in sandbox too =)
There was a problem hiding this comment.
it would be just as right to say: Run a command outside the sandbox
There was a problem hiding this comment.
Yeah, the --host argument kinda totally changes this, but i think it makes sense to document what it does by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetics