Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elementary OS instructions for 5.1+ #355

Merged
merged 2 commits into from Oct 30, 2019

Conversation

@cassidyjames
Copy link
Contributor

cassidyjames commented Oct 29, 2019

As of elementary OS 5.1 up-to-date Flatpak is included in the repo and preinstalled, AppCenter supports Flatpak ootb, and the preinstalled Sideload app handles .flatpakref files. Since 5.0 users are upgraded to 5.1 and older versions are EOL, there's no need for older instructions.

Installing an app from a .flatpakref with Sideload also adds its remote, so there's no need to add it separately.

I also tweaked the language for talking about Flathub, since curated AppCenter apps will be moving to use Flatpak by default from the elementary AppCenter remote, so users just wanting to get "Flatpak" on elementary OS will already have it. But this still directs them to Flathub for what elementary refers to as "non-curated" apps.

As of elementary OS 5.1 up-to-date Flatpak is included in the repo and preinstalled, AppCenter supports Flatpak ootb, and the preinstalled Sideload app handles .flatpakref files. Since 5.0 users are upgraded to 5.1 and older versions are EOL, there's no need for older instructions.

Installing an app from a .flatpakref with Sideload also adds its remote, so there's no need to add it separately.
@TingPing

This comment has been minimized.

Copy link
Member

TingPing commented Oct 29, 2019

I think the Flathub section should remain as-is just to be consistent and clear.

@cassidyjames

This comment has been minimized.

Copy link
Contributor Author

cassidyjames commented Oct 29, 2019

@TingPing it's completely unnecessary (and very non-elementary) to direct users to the Terminal, though. It makes it seem more complicated to add Flathub than it really is.

@TingPing

This comment has been minimized.

Copy link
Member

TingPing commented Oct 29, 2019

The problem is you made a circular reference that doesn't help the user.

flatpak.org setup says "go to flathub" -> flathub.org setup says "see flatpak.org".

You can document the graphical workflow if you prefer linking to the .flatpakrepo file directly.

@cassidyjames

This comment has been minimized.

Copy link
Contributor Author

cassidyjames commented Oct 29, 2019

@TingPing I don't see how anything I did is circular. The setup guide amounts to: you're already set up, go install stuff. It's not substantially different than PureOS except manually adding the repo is not needed so you can just go install stuff. And nearly every OS's instructions link to Flathub at the end so I was keeping that at least somewhat consistent.

Clicking the big "Install" button on Flathub already links to the .flatpakrepo which works correctly on elementary OS. Documenting that seems entirely convoluted.

If you'd prefer, I can echo the Linux Mint instructions and just say that Flatpak is already set up and ready to go in elementary OS instead.

@TingPing

This comment has been minimized.

Copy link
Member

TingPing commented Oct 29, 2019

Mint has Flathub pre-configured that is why it is omitted. elementary does not so I think it is valuable to say how. (And no the normal install button is not the same as adding a repo normally. Again you can just link to the repo file.)

@TingPing

This comment has been minimized.

Copy link
Member

TingPing commented Oct 30, 2019

Tell users to hit the big obvious button

I don't understand why you are so against users just adding the repo. Surely you understand the workflow is entirely different than installing an app from the website.

@cassidyjames

This comment has been minimized.

Copy link
Contributor Author

cassidyjames commented Oct 30, 2019

@TingPing because telling people to open Terminal means we've already failed. And it is not needed on elementary OS, since Sideload does that automatically when installing an app. There is no need to add extra steps—especially ones involving Terminal—for elementary OS users.

If at some point Sideload handled .flatpakrepo files as well we could direct users to do that (like the PureOS directions), but that's not the case today, and using Sideload is the recommended way to get Flatpaks.

@TingPing

This comment has been minimized.

Copy link
Member

TingPing commented Oct 30, 2019

OK, sideload doesn't support repo files is all you had to say. I think this is still a bad solution but oh well.

@TingPing TingPing merged commit f1afd24 into flatpak:source Oct 30, 2019
1 check failed
1 check failed
LGTM analysis: JavaScript No code changes detected
Details
@cassidyjames cassidyjames deleted the cassidyjames:patch-1 branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.