flatpak-oci-authenticator: try getting a token without credentials #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch?
|
Some registries require getting a token even to download an image anonymously. So, if no auth has been configured, before prompting the user for username/password, try without a BasicAuth header. Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
owtaylor
force-pushed
the
oci-registry-no-credentials-token
branch
from
0b1ab04
to
24e485d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some registries require getting a token even to download an image
anonymously. So, if no auth has been configured, before prompting
the user for username/password, try without a BasicAuth header.
Signed-off-by: Owen W. Taylor otaylor@fishsoup.net
Another approach would be to handle this without going to the authenticator at all - if we get UNAUTHORIZED response with a WWW-Authenticate and don't have a token, try to get one anonymously. This patch posits that maybe we'll change things so that OCI remotes always have the OCI authenticator configured by default, and always try to get a token for every image.