Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make xa.redirect-url handling configurable #3603

Merged
merged 3 commits into from Jun 8, 2020
Merged

Conversation

barthalion
Copy link
Member

@barthalion barthalion commented May 6, 2020

Assume that if user explicitly modifies the URL, they want to keep
using that URL instead of having it overwritten by xa.redirect-url.

Add switches to remote-add and remote-modify for uniformity.

@alexlarsson
Copy link
Member

alexlarsson commented May 11, 2020

I don't like the argument name --redirect. It feels like its a command that should redirect something, which it isn't. Maybe --follow-redirect?

Assume that if user explicitly modifies the URL, they want to keep
using that URL instead of having it overwritten by xa.redirect-url.
@alexlarsson
Copy link
Member

alexlarsson commented Jun 8, 2020

Rebased as --follow-redirect/--no-follow-redirect

@alexlarsson alexlarsson merged commit 6d9f927 into master Jun 8, 2020
6 checks passed
@mwleeds mwleeds deleted the remote-redirect branch Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants