Fix argument order of clone() for s390x in seccomp filter #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clone() is a mad syscall with about 4 different argument orders. While most of them agree that argument 0 is flags, s390 and s390x have the flags argument second - A0 is the child stack pointer there. [smcv: Add an explanatory comment; also test __CRIS__ for completeness] Bug-Debian: https://bugs.debian.org/964541 Bug-Ubuntu: https://launchpad.net/bugs/1886814 Signed-off-by: Simon McVittie <smcv@collabora.com>
gnomesysadmins
pushed a commit
to GNOME/gnome-desktop
that referenced
this pull request
Aug 6, 2020
From flatpak/flatpak#3777 clone() is a mad syscall with about 4 different argument orders. While most of them agree that argument 0 is flags, s390 and s390x have the flags argument second - A0 is the child stack pointer there. [smcv: Add an explanatory comment; also test __CRIS__, for completeness; apply change from Flatpak to the copy of this code in gnome-desktop] Bug-Debian: https://bugs.debian.org/964541 Bug-Ubuntu: https://launchpad.net/bugs/1886814 Signed-off-by: Simon McVittie <smcv@collabora.com>
|
I believe you can actually run GUI apps on s390 machines using VNC or other remote desktop protocols. :) |
ashkulz
pushed a commit
to qtwebkit/webkit-mirror
that referenced
this pull request
Aug 8, 2020
…390x https://bugs.webkit.org/show_bug.cgi?id=215212 Reviewed by Michael Catanzaro. Patch based on this Flatpak pull request: flatpak/flatpak#3777 No new tests needed. * UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::setupSeccomp): Add preprocessor guard to choose the correct clone() system call argument on S390. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@265326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
gnomesysadmins
pushed a commit
to GNOME/gnome-desktop
that referenced
this pull request
Aug 10, 2020
From flatpak/flatpak#3777 clone() is a mad syscall with about 4 different argument orders. While most of them agree that argument 0 is flags, s390 and s390x have the flags argument second - A0 is the child stack pointer there. [smcv: Add an explanatory comment; also test __CRIS__, for completeness; apply change from Flatpak to the copy of this code in gnome-desktop] Bug-Debian: https://bugs.debian.org/964541 Bug-Ubuntu: https://launchpad.net/bugs/1886814 Signed-off-by: Simon McVittie <smcv@collabora.com>
gnomesysadmins
pushed a commit
to GNOME/gnome-desktop
that referenced
this pull request
Aug 11, 2020
From flatpak/flatpak#3777 clone() is a mad syscall with about 4 different argument orders. While most of them agree that argument 0 is flags, s390 and s390x have the flags argument second - A0 is the child stack pointer there. [smcv: Add an explanatory comment; also test __CRIS__, for completeness; apply change from Flatpak to the copy of this code in gnome-desktop] Bug-Debian: https://bugs.debian.org/964541 Bug-Ubuntu: https://launchpad.net/bugs/1886814 Signed-off-by: Simon McVittie <smcv@collabora.com>
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Aug 18, 2020
…ccomp filter on s390x https://bugs.webkit.org/show_bug.cgi?id=215212 Reviewed by Michael Catanzaro. Patch based on this Flatpak pull request: flatpak/flatpak#3777 No new tests needed. * UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::setupSeccomp): Add preprocessor guard to choose the correct clone() system call argument on S390. git-svn-id: http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.28@265737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 1, 2022
…ccomp filter on s390x https://bugs.webkit.org/show_bug.cgi?id=215212 Reviewed by Michael Catanzaro. Patch based on this Flatpak pull request: flatpak/flatpak#3777 No new tests needed. * UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::setupSeccomp): Add preprocessor guard to choose the correct clone() system call argument on S390.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: @julian-klode
clone() is a mad syscall with about 4 different argument orders. While
most of them agree that argument 0 is flags, s390 and s390x have the
flags argument second - A0 is the child stack pointer there.
[smcv: Add an explanatory comment; also test
__CRIS__for completeness]Bug-Debian: https://bugs.debian.org/964541
Bug-Ubuntu: https://launchpad.net/bugs/1886814
For reference see clone(2), https://github.com/systemd/systemd/blob/master/src/basic/raw-clone.h and kernel source.
I'm told that this change is necessary and sufficient to make flatpak-builder work on s390x, for everyone who wants to be able to build desktop applications for their non-GUI-capable IBM mainframe (if such users even exist).
This is currently considered to be a release-critical bug in Debian and Ubuntu, because those distributions don't distinguish between architectures where desktop-oriented packages are practically useful and architectures where they are not.