Some fixes to 'sandbox-a11y-own-name'#5951
Merged
GeorgesStavracas merged 3 commits intoOct 3, 2024
Merged
Conversation
It loops twice and adds the same values, which is unnecessary.
When merging, marking a context as sandboxed, etc, also propagate and apply the a11y policies stored. Fixes 915bbfb
The original intention was to add 'sandbox-a11y-own-names', which would match the prefix of other arguments, and it's what was documented in the D-Bus XML and in flatpak-spawn too. Fixes 8ec21a2
TingPing
reviewed
Oct 1, 2024
TingPing
left a comment
TingPing
left a comment
Member
There was a problem hiding this comment.
LGTM.
Only thing I would say some of this should be pulled out into functions like flatpak_context_save_metadata() has a lot of repetition.
Collaborator
|
LGTM as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context: Remove duplicated hash table loop
It loops twice and adds the same values, which is unnecessary.
context: Consider a11y policies too
When merging, marking a context as sandboxed, etc, also propagate and
apply the a11y policies stored.
Fixes 915bbfb
portal: Fix 'sandboxed' → 'sandbox'
The original intention was to add 'sandbox-a11y-own-names', which would
match the prefix of other arguments, and it's what was documented in the
D-Bus XML and in flatpak-spawn too.
Fixes 8ec21a2
I was finally able to test this from start to end, with the release of flatpak-xdg-utils 1.0.6. GNOME Web built with WebKit/WebKit#32247, and this branch, is able to connect the a11y trees across sandboxes.