Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Peer to peer and unsigned summary file support #884
Here’s my branch which adds support for installing/updating apps/runtimes from LAN/USB, including the necessary support for unsigned summary files and the
It adds a new
There are also a bunch of
It adds a couple of new tests, but there are bound to be quite a few corner cases which I haven’t handled yet. I plan to test it for a while with
So, i had a quick look at tihs code, and overall it looks reasonable.
First of all (as i wrote in the comment) is that we want to continue relying on just downloading the summary file, and then have all the data we need for e.g command line completion, automatic dependency resolution (i.e. know what runtime and extensions are affected when installing/updating), etc. We don't want to actually download all the commits in the repo.
Secondly, I worry a bit about all the mentionings of things being racy in the dynamic case. We do a search for revs at one point, surely we remember then also which rev came from where in the results we carry forward? We don't ask some randomly picked remote about some rev that some other remote said it had?
I did originally have a commit which added one, but then I realised the new API was never actually used, so I dropped the commit so that the API diff was minimised. I was thinking it could be added later once someone actually needs it.
(Adding public API which is ‘experimental’ turns into a large amount of pain in terms of advertising it in the pkg-config file, guarding it in the headers correctly for internal and potential external use, conditionally putting it in the documentation, etc.)
This branch does continue to rely on the metadata from the
added a commit
this pull request
Jul 4, 2017
I’ve just force-pushed an updated version of the branch, rebased on master and with quite a few fixes squashed in. It should now have all the necessary
This was referenced
Jul 11, 2017
I found a few minor things to point out but after that this seems ready to merge.
A few comments to address, then this should be good to land. Comments from @alexlarsson by e-mail:
On the plane I took a look at the p2p branch, in particular how it affects the non-p2p case. I found a few issues listed below, but otherwise I think this looks good to land now.
Other things which we discussed which I need to do/look at:
I’ve got a WIP branch here which changes gnome-software to ignore non-static remotes for now:
I can’t find such a parser. The code around line 2700 of
WIP branch (which will be submitted to bugzilla.gnome.org eventually) here: https://github.com/pwithnall/gnome-software/tree/lan-and-usb
Did you do this? I’m not sure of a good way/place to state that it’s unsupported.