Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support snap #155
This PR includes the changes from #154, but we should probably land those separately first.
This should handle the basics of portals, but there are two things still missing:
Sorry for taking so long with this. After I made the change to
aa_is_enabled, the portal detected snap confined applications correctly.
For testing, I used a snapped version of portal-test:
I'm also running the following patch to snapd: https://github.com/snapcore/snapd/compare/master...jhenstridge:xdg-desktop-portal-support?expand=1
(I don't currently have document-portal support rolled in: that's still coming).
I used the screenshot test because there is currently an http/https scheme handler in the snap environment, which is picked before trying the portal.
The portal prompted me to grant permission to make the screenshot available. Like my original PR, we don't have any app info apart from the ID at the moment, so the UI shows the app name as "(null)". That seems to be more about how xdg-desktop-portal-gtk looks up the application info though, which should be solvable.