background-portal: Stop sending app-id quoted#778
Conversation
|
While 28ec93c mentions
I think the commit misses excluding the app-id from quoting for the background portal. |
3e2e125 to
7f67cac
Compare
|
Thanks for fixing the coding style! |
804aaf7 to
46ed6ca
Compare
|
@mleeds @GeorgesStavracas You authored/merged the original changes. Maybe you can have a look at this? As I see it the implications of this bug are that, for example, background processes for scheduled backups are not started. IIRC the autostart file is never rewritten. That means if anyone sets up the app with 1.14.0 to 1.14.3 the autostart file might never get automatically fixed. Therefore it feels somewhat urgent for me to release this fix. |
GeorgesStavracas
left a comment
There was a problem hiding this comment.
Please squash the second commit with the first one. LGTM otherwise.
46ed6ca to
4f94051
Compare
Done :) |
Since flatpak#696, the arguments sent to background portal implementations contained the app-id in quoted form. Implementations, in turn, created invalid autostart files.
4f94051 to
a6faf19
Compare
Since #696, the arguments sent to background portal implementations
contained the app-id in quoted form. Implementations, in turn, created
invalid autostart files.