New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating Taxprice not properly working #51

Closed
carlu93 opened this Issue Mar 29, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@carlu93
Contributor

carlu93 commented Mar 29, 2017

I can't get the Taxprice to be included in the calculation. Although the Country is allowed, the tax doesn't get added to the total price.
If i comment line 210 "if (country.isAllowed)" in shoppingcart_cart.js it gets picked up and calculated.
I attached my shoppingcart.yaml. I think this might be a bug. If you need more information, just tell me.
Thanks a ton!
shoppingcart.txt

@flaviocopes

This comment has been minimized.

Owner

flaviocopes commented Mar 30, 2017

Can you post a PR with your change?

@carlu93

This comment has been minimized.

Contributor

carlu93 commented Mar 30, 2017

I don't know if i'm capable to do that. The Change is also only working if taxes are EXCLUDED not included. I came up with the solution by trial and error. I'm currently in my exam phase. After the 8th of April i might have time to look deeper into it and come up with a solution or more info on the problem. sorry :/
edit: Also i put two bugs in this report. I'll open another one for the Subtotal label... Sorry for that. I'm pretty new to all the github stuff 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment