New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add to cart"-button functionality on products list page. Updated #35

Merged
merged 6 commits into from Jul 20, 2016

Conversation

Projects
None yet
2 participants
@hectorromo
Contributor

hectorromo commented Jul 9, 2016

Hi @flaviocopes ,
Here is my pull request for adding Add to cart buttons as an option when displaying multiple products.

I added an option on shopping_products template so you can decide whether you want to display Details or Add to cart button on products. Didn't want to add another template file, the styling is not updated though.

(The first pull request was a bit quirky in the templates.)

<i class="fa fa-info-circle"></i> {{ 'PLUGIN_SHOPPINGCART.DETAILS'|t }}
</a>
</p>
{% if page.header.pay_what_you_want %}

This comment has been minimized.

@flaviocopes

flaviocopes Jul 11, 2016

Owner

Is this one variable you are using? Can this be removed from the plugin core, maybe you can add it to your own theme twig override?

This comment has been minimized.

@hectorromo

hectorromo Jul 11, 2016

Contributor

This should say:
{% if page.header.display_add_to_cart %}

@hectorromo

This comment has been minimized.

Contributor

hectorromo commented Jul 11, 2016

Sorry, that line shouldn't be there, it's a variable for a plugin I'm making.

@@ -0,0 +1,31 @@
title: Product

This comment has been minimized.

@flaviocopes

flaviocopes Jul 11, 2016

Owner

Use "Products List" maybe

This comment has been minimized.

@hectorromo

hectorromo Jul 11, 2016

Contributor

Yes, I agree.

@flaviocopes flaviocopes merged commit 4b250bb into flaviocopes:develop Jul 20, 2016

@flaviocopes

This comment has been minimized.

Owner

flaviocopes commented Jul 20, 2016

Checked and works, thanks! Just an issue with adding more than 1 product, it's not working as expected, always adds one, but I have a fix already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment