Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Add chunk parameter of overloaded finish method

Problem example:
RequestHandler calls write_error() which in turn calls self.finish() with a chunk parameter, leading to the uncaught exception "TypeError: finish() takes exactly 1 argument (2 given)"
  • Loading branch information...
commit 2737f65b9108a6fa25265f89ff502e13c3c08519 1 parent a018cc1
@frwickst frwickst authored
Showing with 2 additions and 2 deletions.
  1. +2 −2 sockjs/cyclone/basehandler.py
View
4 sockjs/cyclone/basehandler.py
@@ -32,11 +32,11 @@ def _log_disconnect(self):
self.server.stats.connectionClosed()
self.logged = False
- def finish(self):
+ def finish(self, chunk=None):
""" Cyclone C{finish} handler """
self._log_disconnect()
- super(BaseHandler, self).finish()
+ super(BaseHandler, self).finish(chunk)
def on_connection_close(self, reason):
self._log_disconnect()
Please sign in to comment.
Something went wrong with that request. Please try again.