New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby test failures #88

Open
flavorjones opened this Issue May 5, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@flavorjones
Owner

flavorjones commented May 5, 2015

So many test failures. What is going on?

@jkraemer

This comment has been minimized.

Show comment
Hide comment
@jkraemer

jkraemer Jul 20, 2015

Which basically blocks the use of Rails 4.2 with JRuby, at least if you are concerned about working html sanitization.

Most if not all of the problems seem to be Nokogiri-Java problems where it behaves different from C-Nokogiri. I started working on some Nokogiri test cases that reproduce what loofah does, see sparklemotion/nokogiri#1318, sparklemotion/nokogiri#1319 and sparklemotion/nokogiri#1320. At least the last one looks more like a Xalan-J bug...

Which basically blocks the use of Rails 4.2 with JRuby, at least if you are concerned about working html sanitization.

Most if not all of the problems seem to be Nokogiri-Java problems where it behaves different from C-Nokogiri. I started working on some Nokogiri test cases that reproduce what loofah does, see sparklemotion/nokogiri#1318, sparklemotion/nokogiri#1319 and sparklemotion/nokogiri#1320. At least the last one looks more like a Xalan-J bug...

@flavorjones

This comment has been minimized.

Show comment
Hide comment
Owner

flavorjones commented Feb 13, 2017

Much of this is:

which may be addressed in sparklemotion/nokogiri#1604

@flavorjones flavorjones referenced this issue Feb 13, 2017

Merged

this isit #1604

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Nov 12, 2017

Ping! Trying to get JRuby deps cleaned up again now that we support Rails 5.

headius commented Nov 12, 2017

Ping! Trying to get JRuby deps cleaned up again now that we support Rails 5.

@flavorjones

This comment has been minimized.

Show comment
Hide comment
@flavorjones

flavorjones Nov 12, 2017

Owner

@headius We (nokogiri core) need help on the JRuby implementation. I've pinged you and other members of the JRuby community a few times since November 2014 on the subject, so hopefully that's not surprising news.

Taking a look at the most recent failing pipeline:

https://ci.nokogiri.org/teams/nokogiri-core/pipelines/loofah/jobs/jruby-9.1/builds/12

most of these failures are what I'd refer to as "soft" failures, meaning that the markup is sanitized properly, but there are minor formatting differences that can be attributed to small differences in the parsing engines.

There are a few, however, that are NPEs, and for those I'd welcome PRs to Nokogiri to fix them.

Additionally, there are about 30 open issues for Nokogiri that are labeled jruby, and I'd welcome help with those as well.

Owner

flavorjones commented Nov 12, 2017

@headius We (nokogiri core) need help on the JRuby implementation. I've pinged you and other members of the JRuby community a few times since November 2014 on the subject, so hopefully that's not surprising news.

Taking a look at the most recent failing pipeline:

https://ci.nokogiri.org/teams/nokogiri-core/pipelines/loofah/jobs/jruby-9.1/builds/12

most of these failures are what I'd refer to as "soft" failures, meaning that the markup is sanitized properly, but there are minor formatting differences that can be attributed to small differences in the parsing engines.

There are a few, however, that are NPEs, and for those I'd welcome PRs to Nokogiri to fix them.

Additionally, there are about 30 open issues for Nokogiri that are labeled jruby, and I'd welcome help with those as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment