Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
jruby test failures #88
Which basically blocks the use of Rails 4.2 with JRuby, at least if you are concerned about working html sanitization.
Most if not all of the problems seem to be Nokogiri-Java problems where it behaves different from C-Nokogiri. I started working on some Nokogiri test cases that reproduce what loofah does, see sparklemotion/nokogiri#1318, sparklemotion/nokogiri#1319 and sparklemotion/nokogiri#1320. At least the last one looks more like a Xalan-J bug...
This was referenced
Sep 1, 2015
I have confirmed sparklemotion/nokogiri#1318 reduces jruby errors.
@headius We (nokogiri core) need help on the JRuby implementation. I've pinged you and other members of the JRuby community a few times since November 2014 on the subject, so hopefully that's not surprising news.
Taking a look at the most recent failing pipeline:
most of these failures are what I'd refer to as "soft" failures, meaning that the markup is sanitized properly, but there are minor formatting differences that can be attributed to small differences in the parsing engines.
There are a few, however, that are NPEs, and for those I'd welcome PRs to Nokogiri to fix them.
Additionally, there are about 30 open issues for Nokogiri that are labeled