Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging needs to offer more information #53

Closed
mweinelt opened this issue Feb 24, 2020 · 0 comments
Closed

Logging needs to offer more information #53

mweinelt opened this issue Feb 24, 2020 · 0 comments
Assignees
@fleaz
Labels
enhancement New feature or request

Comments

@mweinelt
Copy link
Contributor

mweinelt commented Feb 24, 2020 •
edited
Loading

I've set logging to INFO and DEBUG but neither offer much information on whats happening, like incoming webhooks or irc connects/disconnects and messages going in/out. This makes it hard to find out what state CptHook is currently in, like when it doesn't connect or reconnect to IRC.

Feb 25 00:47:02 elsa CptHook[3749]: time="2020-02-25T00:47:02+01:00" level=info msg="Setting loglevel defined by configuration" fields.level=debug
Feb 25 00:47:02 elsa CptHook[3749]: time="2020-02-25T00:47:02+01:00" level=info msg="Loaded module \"prometheus\""
Feb 25 00:47:02 elsa CptHook[3749]: time="2020-02-25T00:47:02+01:00" level=warning msg="found configuration for unknown module: \"status\""
Feb 25 00:47:02 elsa CptHook[3749]: time="2020-02-25T00:47:02+01:00" level=info msg="Loaded module \"gitlab\""
Feb 25 00:47:02 elsa CptHook[3749]: time="2020-02-25T00:47:02+01:00" level=info msg="Started HTTP Server" listen=":8086"
Feb 25 00:47:02 elsa CptHook[3749]: time="2020-02-25T00:47:02+01:00" level=info msg="ChannelReceiver started"
Feb 25 00:47:14 elsa CptHook[3749]: time="2020-02-25T00:47:14+01:00" level=debug msg="Need to join new channel" channel="#ffda-mon"
Feb 25 00:47:14 elsa CptHook[3749]: time="2020-02-25T00:47:14+01:00" level=debug msg="Need to join new channel" channel=

Also the escaping of quoted values is weird.
@fleaz fleaz self-assigned this Feb 25, 2020
@fleaz fleaz added the enhancement New feature or request label Feb 25, 2020
fleaz added a commit that referenced this issue May 24, 2020
@fleaz
Improved logging
4a38dc7 
Made better use of warn/info/debug levels.
Introduced LogginMiddleware to router.
Removed second logging library from project.
Fixes #53.
@fleaz fleaz closed this as completed in 59369ff Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fleaz fleaz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweinelt @fleaz