From 3c2ca2b279da6e677a6bbb8464bee78a185999ad Mon Sep 17 00:00:00 2001 From: ndonkoHenri Date: Sat, 9 Sep 2023 02:54:06 +0200 Subject: [PATCH 1/2] Simplify chained comparison --- sdk/python/packages/flet-core/src/flet_core/audio.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/python/packages/flet-core/src/flet_core/audio.py b/sdk/python/packages/flet-core/src/flet_core/audio.py index 3ecc25c5e..5d2c284e8 100644 --- a/sdk/python/packages/flet-core/src/flet_core/audio.py +++ b/sdk/python/packages/flet-core/src/flet_core/audio.py @@ -187,7 +187,7 @@ def volume(self) -> OptionalNumber: @volume.setter def volume(self, value: OptionalNumber): - if value is None or (value >= 0 and value <= 1): + if value is None or (0 <= value <= 1): self._set_attr("volume", value) # balance @@ -197,7 +197,7 @@ def balance(self) -> OptionalNumber: @balance.setter def balance(self, value: OptionalNumber): - if value is None or (value >= -1 and value <= 1): + if value is None or (-1 <= value <= 1): self._set_attr("balance", value) # playback_rate @@ -207,7 +207,7 @@ def playback_rate(self) -> OptionalNumber: @playback_rate.setter def playback_rate(self, value: OptionalNumber): - if value is None or (value >= 0 and value <= 2): + if value is None or (0 <= value <= 2): self._set_attr("playbackRate", value) # release_mode From 031d99381086ceb93b485e9b06354d076c21d731 Mon Sep 17 00:00:00 2001 From: ndonkoHenri Date: Sat, 9 Sep 2023 02:55:40 +0200 Subject: [PATCH 2/2] typo: "agnle" -> "angle" --- sdk/python/packages/flet-core/src/flet_core/canvas/arc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/python/packages/flet-core/src/flet_core/canvas/arc.py b/sdk/python/packages/flet-core/src/flet_core/canvas/arc.py index 6bbe9c737..9e78a5dd5 100644 --- a/sdk/python/packages/flet-core/src/flet_core/canvas/arc.py +++ b/sdk/python/packages/flet-core/src/flet_core/canvas/arc.py @@ -12,7 +12,7 @@ def __init__( y: OptionalNumber = None, width: OptionalNumber = None, height: OptionalNumber = None, - start_agnle: OptionalNumber = None, + start_angle: OptionalNumber = None, sweep_angle: OptionalNumber = None, use_center: Optional[bool] = None, paint: Optional[Paint] = None, @@ -28,7 +28,7 @@ def __init__( self.y = y self.width = width self.height = height - self.start_angle = start_agnle + self.start_angle = start_angle self.sweep_angle = sweep_angle self.use_center = use_center self.paint = paint