-
Notifications
You must be signed in to change notification settings - Fork 600
Upgrade to Flutter 3.38.2 #5851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped the required Flutter version to 3.38.2 in .fvmrc and build.py. Updated several Dart dependencies in pubspec.lock and removed path_provider_foundation from macOS plugin registration to reflect dependency changes.
Revised the cache-key and pub-cache-key formats in the CI workflow to use placeholders (:os:, :channel:, :version:, :hash:) instead of GitHub Actions variables. This may improve cache management and compatibility with the flutter-fvm-config-action.
Modified cache-key and pub-cache-key in CI and macOS integration workflows to include architecture. This improves cache granularity and prevents issues when running workflows on different architectures.
Set 'cache' to false in the flutter-fvm-config-action setup steps for both CI and macOS integration test workflows. This change disables caching to potentially resolve issues related to cache usage or improve workflow reliability.
Introduces a cache step for Flutter in both CI and macOS integration test workflows using actions/cache. This improves build performance by reusing Flutter dependencies between runs.
Introduces a step in both CI and macOS integration test workflows to print the Flutter cache path and key outputs. This aids in debugging and verifying cache configuration during workflow runs.
Replaces kuhnroyal/flutter-fvm-config-action/setup with subosito/flutter-action for Flutter setup in both ci.yml and macos-integration-tests.yml. Adds a separate step to configure Flutter version using .fvmrc and removes printing of Flutter outputs.
Introduces a 'spacing' property to CupertinoCheckbox for customizing the space between the checkbox and its label. Updates Dart and Python implementations, integration tests, and golden images to reflect this change. Also refactors test cases for improved clarity and coverage. Flutter change: flutter/flutter#172502
Refreshed golden images for submenu button and time picker integration tests on macOS to reflect recent UI or rendering changes.
Introduces proper mouse pointer exit before tap, long press, and text entry actions to avoid lingering gestures. Updates mouse hover logic to manage gesture lifecycle. Also updates navigation bar test destinations and golden images for macOS time picker and navigation bar.
Replaces the macOS dropdown theme_1.png golden image in integration tests to reflect updated visual output or design changes.
Replaces the menu_bar_basic_open.png golden image used in integration tests for the macOS menu bar control. This ensures test accuracy with the latest UI changes.
Eliminated redundant _mouseExit() calls before tap, longPress, and enterText actions in FlutterWidgetTester to streamline test interactions. Also updated golden image for navigation bar theme on macOS.
Introduces a 'persist' property to the SnackBar control in Dart and Python, allowing developers to specify whether the snack bar should remain visible after the timeout. Updates documentation and example usage to reflect the new option. Breaking change: https://docs.flutter.dev/release/breaking-changes/snackbar-with-action-behavior-update
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
Changed the type of the spacing property from Number to Optional[Number] in CupertinoCheckbox to allow for None values and improve flexibility.
FeodorFitsner
added a commit
that referenced
this pull request
Nov 23, 2025
…ied/intelligent `src` prop (#5817) * initial commit * update examples * tests * `enable_merge_paths=False` by default * improve URL and file path handling in image resolution * `Slider`: pass value to change event * Refactor image source handling in controls and improve image provider methods * more tests * Fix image source parameter in canvas test * fix #5615: Refactor DashedStrokePattern validation and improve segments handling * Add tip for scrollable content in bottom sheet documentation * Refactor asset source resolution and minor code cleanup Replaced ResolvedAssetSource.from(...get('src')) with getSrc('src') in audio and lottie Dart files for improved asset source resolution. Cleaned up argument formatting and improved readability in lottie.dart. Updated brush.py to use src_bytes instead of src for file saving. Removed unused page argument and debug print statements from image_switch_buffered.py. * Upgrade to Flutter 3.38.2 (#5851) * Update Flutter version to 3.38.2 and dependencies Bumped the required Flutter version to 3.38.2 in .fvmrc and build.py. Updated several Dart dependencies in pubspec.lock and removed path_provider_foundation from macOS plugin registration to reflect dependency changes. * Update ci.yml * Update Flutter cache key format in CI workflow Revised the cache-key and pub-cache-key formats in the CI workflow to use placeholders (:os:, :channel:, :version:, :hash:) instead of GitHub Actions variables. This may improve cache management and compatibility with the flutter-fvm-config-action. * Update Flutter cache keys to include architecture Modified cache-key and pub-cache-key in CI and macOS integration workflows to include architecture. This improves cache granularity and prevents issues when running workflows on different architectures. * Disable cache in Flutter FVM setup actions Set 'cache' to false in the flutter-fvm-config-action setup steps for both CI and macOS integration test workflows. This change disables caching to potentially resolve issues related to cache usage or improve workflow reliability. * Add Flutter caching to CI workflows Introduces a cache step for Flutter in both CI and macOS integration test workflows using actions/cache. This improves build performance by reusing Flutter dependencies between runs. * Add step to print Flutter cache outputs in CI Introduces a step in both CI and macOS integration test workflows to print the Flutter cache path and key outputs. This aids in debugging and verifying cache configuration during workflow runs. * Update Flutter setup in CI workflows Replaces kuhnroyal/flutter-fvm-config-action/setup with subosito/flutter-action for Flutter setup in both ci.yml and macos-integration-tests.yml. Adds a separate step to configure Flutter version using .fvmrc and removes printing of Flutter outputs. * Add spacing option to CupertinoCheckbox label Introduces a 'spacing' property to CupertinoCheckbox for customizing the space between the checkbox and its label. Updates Dart and Python implementations, integration tests, and golden images to reflect this change. Also refactors test cases for improved clarity and coverage. Flutter change: flutter/flutter#172502 * Update golden images for macOS material tests Refreshed golden images for submenu button and time picker integration tests on macOS to reflect recent UI or rendering changes. * Improve mouse gesture handling in FlutterWidgetTester Introduces proper mouse pointer exit before tap, long press, and text entry actions to avoid lingering gestures. Updates mouse hover logic to manage gesture lifecycle. Also updates navigation bar test destinations and golden images for macOS time picker and navigation bar. * Update dropdown theme_1.png golden image Replaces the macOS dropdown theme_1.png golden image in integration tests to reflect updated visual output or design changes. * Update golden image for macOS menu bar test Replaces the menu_bar_basic_open.png golden image used in integration tests for the macOS menu bar control. This ensures test accuracy with the latest UI changes. * Remove unnecessary mouse exit calls in FlutterWidgetTester Eliminated redundant _mouseExit() calls before tap, longPress, and enterText actions in FlutterWidgetTester to streamline test interactions. Also updated golden image for navigation bar theme on macOS. * Add 'persist' option to SnackBar control Introduces a 'persist' property to the SnackBar control in Dart and Python, allowing developers to specify whether the snack bar should remain visible after the timeout. Updates documentation and example usage to reflect the new option. Breaking change: https://docs.flutter.dev/release/breaking-changes/snackbar-with-action-behavior-update * Make spacing property optional in CupertinoCheckbox Changed the type of the spacing property from Number to Optional[Number] in CupertinoCheckbox to allow for None values and improve flexibility. --------- Co-authored-by: Feodor Fitsner <feodor@appveyor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Upgrade Flutter toolchain and align controls, tests, and CI workflows with the new Flutter version.
New Features:
Bug Fixes:
Enhancements:
Build:
CI:
Tests: