-
Notifications
You must be signed in to change notification settings - Fork 14
⚠️ Update RF license warning notebooks #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Spell check passed successfully for 4 notebook(s). |
I'm maybe late to the discussion, but this could in principle have been |
|
Should we disable warnings for RF notebooks until we handle them better? I have already done that for my other notebooks. @weiliangjin2021 |
|
Just merged flexcompute/tidy3d#2460 into develop for this fix. Just texting you in private to explain why this logic was followed Momchil If we want to disable warnings, then we don't have to merge this PR really. |
|
Before I rerun the notebooks with the warning fix, just want to confirm we want to disable warnings or rerun them with the license warning @weiliangjin2021 ? |
I vote for including license warning, unless we have other considerations? |
|
Sounds good to me, I'll rerun the notebooks and commit later tonight (for me)! Or feel free to if you want, these are the relevant ones. |
|
We could disable warnings after the license ones? |
|
Implemented that, just gone through them in detail and they look correct. Ready to merge whenever we want. |
momchil-flex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead! (after squash)
Extra warnings from new validators I think, but apart from that look ok.