Skip to content

Conversation

@daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented May 14, 2025

Extra warnings from new validators I think, but apart from that look ok.

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

Spell check passed successfully for 4 notebook(s).
Generated by GitHub Action run: https://github.com/flexcompute/tidy3d-notebooks/actions/runs/15040415296

@momchil-flex
Copy link
Collaborator

You are have instantiated at least one RF-specific component.        

are needs to be removed.

I'm maybe late to the discussion, but this could in principle have been pre_upload validators? Such that they only show when you try the run the simulation, not when building it (so e.g. they won't show in the solver log).

@dmarek-flex
Copy link
Contributor

Should we disable warnings for RF notebooks until we handle them better? I have already done that for my other notebooks. @weiliangjin2021

https://github.com/flexcompute/tidy3d-notebooks/blob/925aae35bca52a335f116367567f30d589577e43/CharacteristicImpedanceCalculator.ipynb

@daquinteroflex
Copy link
Collaborator Author

daquinteroflex commented May 14, 2025

Just merged flexcompute/tidy3d#2460 into develop for this fix.

Just texting you in private to explain why this logic was followed Momchil

If we want to disable warnings, then we don't have to merge this PR really.

@daquinteroflex
Copy link
Collaborator Author

Before I rerun the notebooks with the warning fix, just want to confirm we want to disable warnings or rerun them with the license warning @weiliangjin2021 ?

@weiliangjin2021
Copy link
Contributor

Before I rerun the notebooks with the warning fix, just want to confirm we want to disable warnings or rerun them with the license warning @weiliangjin2021 ?

I vote for including license warning, unless we have other considerations?

@daquinteroflex
Copy link
Collaborator Author

Sounds good to me, I'll rerun the notebooks and commit later tonight (for me)! Or feel free to if you want, these are the relevant ones.

@momchil-flex
Copy link
Collaborator

We could disable warnings after the license ones?

@daquinteroflex
Copy link
Collaborator Author

Implemented that, just gone through them in detail and they look correct. Ready to merge whenever we want.

Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead! (after squash)

@daquinteroflex daquinteroflex merged commit 739cba2 into develop May 15, 2025
1 check passed
@yaugenst-flex yaugenst-flex deleted the dario/rf_license_warning branch June 27, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants