Skip to content

Check TemperatureMonitor is unstructured in Charge #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

Check TemperatureMonitor is unstructured in Charge #2859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions tidy3d/components/tcad/simulation/heat_charge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,12 +662,10 @@ def check_charge_simulation(cls, values):
"but none have been defined."
)

# NOTE: SteadyPotentialMonitor and SteadyFreeCarrierMonitor are only supported
# for unstructured = True
# NOTE: in Charge we're only supporting unstructured monitors.
# only Temperature and Potential monitors can be structured.
for mnt in monitors:
if isinstance(mnt, SteadyPotentialMonitor) or isinstance(
mnt, SteadyFreeCarrierMonitor
):
if isinstance(mnt, SteadyPotentialMonitor) or isinstance(mnt, TemperatureMonitor):
if not mnt.unstructured:
log.warning(
"Currently, Charge simulations support only unstructured monitors. Please set "
Expand Down
Loading