From 676a02ebce0ff0a71dbb081ff7ce35ff1b07b8f5 Mon Sep 17 00:00:00 2001 From: mahlau-flex Date: Tue, 7 Oct 2025 08:42:38 +0200 Subject: [PATCH] feat: fixed commitlint check in github actions --- .github/workflows/tidy3d-python-client-tests.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/tidy3d-python-client-tests.yml b/.github/workflows/tidy3d-python-client-tests.yml index bd21009efe..f51afc3ecc 100644 --- a/.github/workflows/tidy3d-python-client-tests.yml +++ b/.github/workflows/tidy3d-python-client-tests.yml @@ -163,7 +163,7 @@ jobs: lint-commit-messages: needs: determine-test-scope runs-on: ubuntu-latest - name: veryify-commit-linting + name: lint-commit-messages steps: - name: Check out source code uses: actions/checkout@v4 @@ -534,10 +534,7 @@ jobs: exit 1 # Given remote-tests always run after a PR is approved elif [[ "${{ needs.local-tests.result }}" != 'success' ]]; then echo "❌ local-tests failed or were skipped." - elif [[ "${{ needs.determine-test-scope.outputs.pr_approval_state }}" == 'true' && github.event.pull_request ]]; then - echo "❌ PR requires approval." - exit 1 - elif [[ github.event_name == 'merge_group' && "${{ needs.lint-commit-messages.result }}" != 'success' ]]; then + elif [[ "${{ github.event_name }}" == 'merge_group' && "${{ needs.lint-commit-messages.result }}" != 'success' ]]; then echo "❌ Linting of commit messages failed or was skipped." exit 1 fi