Skip to content

feat: fixed commitlint check in github actions #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

feat: fixed commitlint check in github actions #2868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/tidy3d-python-client-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ jobs:
lint-commit-messages:
needs: determine-test-scope
runs-on: ubuntu-latest
name: veryify-commit-linting
name: lint-commit-messages
steps:
- name: Check out source code
uses: actions/checkout@v4
Expand Down Expand Up @@ -534,10 +534,7 @@ jobs:
exit 1 # Given remote-tests always run after a PR is approved
elif [[ "${{ needs.local-tests.result }}" != 'success' ]]; then
echo "❌ local-tests failed or were skipped."
elif [[ "${{ needs.determine-test-scope.outputs.pr_approval_state }}" == 'true' && github.event.pull_request ]]; then
echo "❌ PR requires approval."
exit 1
elif [[ github.event_name == 'merge_group' && "${{ needs.lint-commit-messages.result }}" != 'success' ]]; then
elif [[ "${{ github.event_name }}" == 'merge_group' && "${{ needs.lint-commit-messages.result }}" != 'success' ]]; then
echo "❌ Linting of commit messages failed or was skipped."
exit 1
fi
Expand Down