Skip to content

FXC-3547-Adding mode sorting to ModeSpec #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

FXC-3547-Adding mode sorting to ModeSpec #2869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Added `CustomImpedanceSpec` for user-defined voltage and current path specifications in impedance calculations.
- Added voltage integral specification classes: `AxisAlignedVoltageIntegralSpec` and `Custom2DVoltageIntegralSpec`.
- Added current integral specification classes: `AxisAlignedCurrentIntegralSpec`, `CompositeCurrentIntegralSpec`, and `Custom2DCurrentIntegralSpec`.
- `sort_spec` in `ModeSpec` allows for fine-grained filtering and sorting of modes. This also deprecates `filter_pol`. The equivalent usage for example to `filter_pol="te"` is `sort_spec=ModeSortSpec(filter_key="TE_polarization", filter_reference=0.5)`. `ModeSpec.track_freq` has also been deprecated and moved to `ModeSortSpec.track_freq`.

### Changed
- Improved performance of antenna metrics calculation by utilizing cached wave amplitude calculations instead of recomputing wave amplitudes for each port excitation in the `TerminalComponentModelerData`.
Expand Down
155 changes: 151 additions & 4 deletions schemas/EMESimulation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5265,6 +5265,24 @@
],
"type": "string"
},
"sort_spec": {
"allOf": [
{
"$ref": "#/definitions/ModeSortSpec"
}
],
"default": {
"attrs": {},
"filter_key": null,
"filter_order": "over",
"filter_reference": 0.0,
"sort_key": null,
"sort_order": "ascending",
"sort_reference": null,
"track_freq": "central",
"type": "ModeSortSpec"
}
},
"target_neff": {
"exclusiveMinimum": 0,
"type": "number"
Expand Down Expand Up @@ -7989,12 +8007,29 @@
],
"type": "string"
},
"sort_spec": {
"allOf": [
{
"$ref": "#/definitions/ModeSortSpec"
}
],
"default": {
"attrs": {},
"filter_key": null,
"filter_order": "over",
"filter_reference": 0.0,
"sort_key": null,
"sort_order": "ascending",
"sort_reference": null,
"track_freq": "central",
"type": "ModeSortSpec"
}
},
"target_neff": {
"exclusiveMinimum": 0,
"type": "number"
},
"track_freq": {
"default": "central",
"enum": [
"central",
"highest",
Expand Down Expand Up @@ -8051,8 +8086,19 @@
0
],
"precision": "double",
"sort_spec": {
"attrs": {},
"filter_key": null,
"filter_order": "over",
"filter_reference": 0.0,
"sort_key": null,
"sort_order": "ascending",
"sort_reference": null,
"track_freq": "central",
"type": "ModeSortSpec"
},
"target_neff": null,
"track_freq": "central",
"track_freq": null,
"type": "ModeSpec"
},
"discriminator": {
Expand Down Expand Up @@ -8266,8 +8312,19 @@
0
],
"precision": "double",
"sort_spec": {
"attrs": {},
"filter_key": null,
"filter_order": "over",
"filter_reference": 0.0,
"sort_key": null,
"sort_order": "ascending",
"sort_reference": null,
"track_freq": "central",
"type": "ModeSortSpec"
},
"target_neff": null,
"track_freq": "central",
"track_freq": null,
"type": "ModeSpec"
}
},
Expand Down Expand Up @@ -8344,6 +8401,79 @@
],
"type": "object"
},
"ModeSortSpec": {
"additionalProperties": false,
"properties": {
"attrs": {
"default": {},
"type": "object"
},
"filter_key": {
"enum": [
"TE_fraction",
"TM_fraction",
"k_eff",
"mode_area",
"n_eff",
"wg_TE_fraction",
"wg_TM_fraction"
],
"type": "string"
},
"filter_order": {
"default": "over",
"enum": [
"over",
"under"
],
"type": "string"
},
"filter_reference": {
"default": 0.0,
"type": "number"
},
"sort_key": {
"enum": [
"TE_fraction",
"TM_fraction",
"k_eff",
"mode_area",
"n_eff",
"wg_TE_fraction",
"wg_TM_fraction"
],
"type": "string"
},
"sort_order": {
"default": "ascending",
"enum": [
"ascending",
"descending"
],
"type": "string"
},
"sort_reference": {
"type": "number"
},
"track_freq": {
"default": "central",
"enum": [
"central",
"highest",
"lowest"
],
"type": "string"
},
"type": {
"default": "ModeSortSpec",
"enum": [
"ModeSortSpec"
],
"type": "string"
}
},
"type": "object"
},
"ModeSpec": {
"additionalProperties": false,
"properties": {
Expand Down Expand Up @@ -8425,12 +8555,29 @@
],
"type": "string"
},
"sort_spec": {
"allOf": [
{
"$ref": "#/definitions/ModeSortSpec"
}
],
"default": {
"attrs": {},
"filter_key": null,
"filter_order": "over",
"filter_reference": 0.0,
"sort_key": null,
"sort_order": "ascending",
"sort_reference": null,
"track_freq": "central",
"type": "ModeSortSpec"
}
},
"target_neff": {
"exclusiveMinimum": 0,
"type": "number"
},
"track_freq": {
"default": "central",
"enum": [
"central",
"highest",
Expand Down
Loading