Skip to content

Conversation

@mahlau-flex
Copy link
Contributor

@mahlau-flex mahlau-flex commented Oct 20, 2025

As suggested by @daquinteroflex, the pre-commit config now uses zizmor without a requirement on poetry

Greptile Overview

Updated On: 2025-10-20 12:57:03 UTC

Greptile Summary

This PR adds zizmor, a security auditing tool for GitHub Actions workflows, to the pre-commit configuration. Zizmor will run automatically on commits to catch potential security issues in CI/CD workflows before they reach the repository. The tool is added via the zizmor-pre-commit repository at version v1.15.2, requiring no changes to existing dependencies or Poetry configuration. This enhances the repository's existing quality gates (Ruff for linting, Commitlint for commit messages) by adding security-focused checks for GitHub Actions workflows defined in .github/workflows/.

Changed Files
Filename Score Overview
.pre-commit-config.yaml 3/5 Adds zizmor security linter hook to pre-commit configuration for auditing GitHub Actions workflows

Confidence score: 3/5

  • This PR is likely safe to merge but requires verification of the external hook repository
  • Score reflects uncertainty about the zizmor-pre-commit repository URL - the official zizmor project repository should be verified as https://github.com/zizmorcore/zizmor-pre-commit may not be the correct/official source (the main zizmor project is at https://github.com/woodruffw/zizmor)
  • Verify the repository URL and that v1.15.2 is a valid tag before merging; if the repository URL is incorrect, the pre-commit hook will fail for all developers

Sequence Diagram

sequenceDiagram
    participant Developer
    participant "Git (pre-commit)" as Git
    participant "Ruff Linter" as Ruff
    participant "Ruff Formatter" as Format
    participant "Commitlint" as Commit
    participant "Zizmor" as Zizmor

    Developer->>Git: "git commit"
    
    Note over Git: pre-commit stage
    Git->>Ruff: "Run ruff-check --fix"
    Ruff-->>Git: "Linting results"
    
    Git->>Format: "Run ruff-format"
    Format-->>Git: "Formatting results"
    
    Note over Git: commit-msg stage
    Git->>Commit: "Run commitlint (non-blocking)"
    Commit-->>Git: "Validation results (exit 0)"
    
    Git->>Zizmor: "Run zizmor linter"
    Zizmor-->>Git: "Security analysis results"
    
    Git-->>Developer: "Commit success/failure"
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@mahlau-flex mahlau-flex force-pushed the FXC-3751-remove-poetry-requirement-from-pre-commit branch from c3e7953 to ed550db Compare October 20, 2025 13:31
@yaugenst-flex yaugenst-flex force-pushed the FXC-3751-remove-poetry-requirement-from-pre-commit branch from ed550db to 4e4b08f Compare October 20, 2025 15:15
@yaugenst-flex yaugenst-flex added this pull request to the merge queue Oct 20, 2025
Merged via the queue into develop with commit ded37cd Oct 20, 2025
25 checks passed
@yaugenst-flex yaugenst-flex deleted the FXC-3751-remove-poetry-requirement-from-pre-commit branch October 20, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants