chore: remove jedi typing (FXC-4160)

[daquinteroflex]

Greptile Summary

• Adds jedi as a required dependency to fix an import error in tidy3d/web/core/http_util.py:12
• The file incorrectly imports Callable from jedi.inference.gradual.typing (an internal jedi API) instead of from the standard library typing.Callable
• This PR treats the symptom rather than the root cause; the import should be fixed to use typing.Callable and jedi removed from required dependencies

Confidence Score: 3/5

• This PR works but adds an unnecessary dependency due to an incorrect import that should be fixed
• The changes are technically correct and will resolve the immediate import error, but they address the symptom rather than fixing the root cause. The code imports Callable from an internal jedi module (jedi.inference.gradual.typing) instead of from Python's standard library (typing), which is incorrect and adds bloat to the dependency tree
• Pay close attention to pyproject.toml - the jedi dependency should be removed once the incorrect import is fixed

Important Files Changed

Filename	Overview
pyproject.toml	Added jedi = "^0.19" as a required dependency (line 44) to fix import error in tidy3d/web/core/http_util.py:12, but the root cause should be addressed

Sequence Diagram

sequenceDiagram
    participant Dev as "Developer"
    participant PR as "This PR"
    participant Deps as "Dependencies"
    participant Code as "http_util.py"
    
    Dev->>Code: "Import Callable from jedi (incorrect)"
    Code->>Deps: "Requires jedi package"
    Deps-->>Code: "Error: jedi not installed"
    Dev->>PR: "Add jedi to pyproject.toml"
    PR->>Deps: "Install jedi as required dependency"
    Deps-->>Code: "jedi now available"
    Code->>Code: "Import works (but still incorrect)"

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format}

[daquinteroflex]

@greptile reevaluate

[greptile-apps]

Looking at the diff, I need to reevaluate my previous assessment. The changes show that the PR actually fixes the incorrect import issue rather than adding jedi as a dependency to work around it.

Corrected Analysis

What the PR actually does:

• ✅ Fixes the root cause: Changes the incorrect import from from jedi.inference.gradual.typing import Callable to the correct from typing import Callable
• ✅ Removes the problematic dependency: By fixing the import, jedi is no longer needed

My previous assessment was wrong - I incorrectly stated that the PR adds jedi as a dependency. Looking at the actual diff, it does the opposite: it fixes the import to use the standard library instead of jedi's internal API.

Updated Evaluation

This is actually a good fix that:

1. Uses the correct, standard library import (typing.Callable)
2. Removes dependency on jedi's internal APIs (which are not meant for external use)
3. Eliminates the need for jedi as a dependency
4. Follows Python best practices

The PR title mentions "include jedi dependency" but the actual changes do the opposite - they remove the need for jedi by fixing the import. The title appears to be misleading or outdated.

Recommendation: Approve - This properly fixes the import issue by using the standard library instead of relying on jedi's internal implementation details.

[momchil-flex]

Ok that makes a lot more sense. :D

[github-actions]

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

• tidy3d/web/core/http_util.py (100%)

Summary

• Total: 1 line
• Missing: 0 lines
• Coverage: 100%