chore: avoid rerun on approval (FXC-3911)

[daquinteroflex]

Greptile Overview

Greptile Summary

Removed GitHub Actions logic that triggered full test suite re-runs when PRs were approved. Previously, the workflow listened to pull_request_review events and would re-execute tests when a reviewer approved the PR. This change eliminates that behavior by:

• Removing the approval status checking step that used GitHub API to determine if a PR was approved
• Removing the pull_request_review event handling logic that ran tests on approval
• Removing the approval state from the pr-requirements-pass job condition
• Simplifying Pandoc installation in the CLI workflow by removing dead code (conditional checks for non-existent matrix strategy)

The binary test file tests/sims/full_fdtd.h5 was regenerated as part of test maintenance.

Confidence Score: 4/5

• This PR is safe to merge with minimal risk - it simplifies CI/CD behavior and removes unnecessary workflow runs
• The changes correctly achieve the stated goal of avoiding re-runs on approval. The workflow will still trigger on PR synchronize events (new pushes), which ensures tests run when code changes. The Pandoc cleanup removes dead code. One minor concern is the unintentional removal of push-to-develop test triggers, which may have been used elsewhere in the workflow.
• Verify that removing push-to-develop triggers in .github/workflows/tidy3d-python-client-tests.yml doesn't break expected CI behavior

Important Files Changed

File Analysis

Filename	Score	Overview
.github/workflows/tidy3d-python-client-tests.yml	4/5	Removed approval-checking logic and pull_request_review trigger handling; simplified test execution to avoid re-running on PR approval
.github/workflows/tidy3d-python-client-develop-cli.yml	3/5	Consolidated Pandoc installation to Ubuntu-only, removing cross-platform support for macOS and Windows

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PR as Pull Request
    participant GHA as GitHub Actions
    participant Tests as Test Suite
    
    Note over Dev,Tests: Before (with approval re-run)
    Dev->>PR: Push new commit
    PR->>GHA: Trigger pull_request event
    GHA->>Tests: Run local tests
    Tests-->>GHA: Tests complete
    
    Dev->>PR: Request review
    PR->>GHA: Trigger pull_request_review (approved)
    GHA->>GHA: Check approval status
    GHA->>Tests: Re-run full test suite (local + remote)
    Tests-->>GHA: Tests complete again
    
    Note over Dev,Tests: After (this PR's changes)
    Dev->>PR: Push new commit
    PR->>GHA: Trigger pull_request event
    GHA->>Tests: Run local tests
    Tests-->>GHA: Tests complete
    
    Dev->>PR: Request review
    Note over PR,GHA: No workflow trigger on approval
    Note over GHA,Tests: Tests not re-run unnecessarily

Loading

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[github-actions]

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.