Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Boost Test and replace with Google Test #146

Merged
merged 11 commits into from
Jul 23, 2016
Merged

Remove Boost Test and replace with Google Test #146

merged 11 commits into from
Jul 23, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 23, 2016

No description provided.

@jslee02 jslee02 added this to the FCL 0.6.0 milestone Jul 23, 2016
@jslee02 jslee02 mentioned this pull request Jul 23, 2016
@sherm1
Copy link
Member

sherm1 commented Jul 23, 2016

This looks great, JS -- I'm really happy to see boost evaporating! One suggestion: rather than using Google's TEST macro use GTEST_TEST. TEST is a mistake Google made (in violation of its own standards I think) in creating a macro with such a common name that it conflicts with other code. Hence the need for this kludge in the google test manual. Other mistakes were SUCCEED and FAIL. I suggest defining the provided GTEST_DONT_DEFINE_TEST etc. macros to avoid the potential for clash with third party or user code.

@jslee02
Copy link
Member Author

jslee02 commented Jul 23, 2016

That's a good suggestion! Done.

@jslee02 jslee02 merged commit 2bef774 into master Jul 23, 2016
@jslee02 jslee02 deleted the gtest branch July 23, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants