Build libccd with double precision on Windows #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherm1
approved these changes
Jun 1, 2017
|
@sherm1 Yeah, I updated the description accordingly. I created this PR without description in motion to quickly trigger the CI tests. 😄 It seems there is a confliction with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCL fails to pass
test_fcl_capsule_box_1test withlibccdbuilt with single precision, which was discovered in #215. To partially address the issue, this PR changes the CI build scripts for Windows to always uselibccdbuilt with double precision.We might want to do similar work for macOS as well.
Unrelated change:
libccdis now built inbuilddirectory.