Some buttons in dialogue boxes are squashed together #5

Closed
flexiondotorg opened this Issue May 19, 2016 · 8 comments

Comments

Projects
None yet
2 participants
Owner

flexiondotorg commented May 19, 2016

See the attached screen shots for comparison.

GTK2

button_spacing_gtk2

GTK3

button_spacing_gtk3

Collaborator

raveit65 commented May 19, 2016

Well linked button are a GTK3 feature and most themes squash them together.
But see how it looks in Menta themes, here the middle buttons don't have round borders, and it looks nice.
But i can also add a margin, in result it looks like gtk2.

Owner

flexiondotorg commented May 19, 2016

The linked button in the Submarine themes looks nice, but I'd prefer something closer to how it was presented in GTK2. Only slight spacing over what we have now is required.

Collaborator

raveit65 commented May 20, 2016

hmm, it looks like
https://developer.gnome.org/gtk3/stable/GtkDialog.html#GtkDialog--s-button-spacing
isn't working any more, so adding something like this does not have any effect.
https://github.com/mate-desktop/mate-themes/blob/gtk3.18/desktop-themes/Blue-Submarine/gtk-3.0/gtk-widgets.css#L20
Also using a margin is still ignored

.message-dialog .linked.dialog-action-area .button {
    margin: 0px 4px 0px 4px;
}

I recall that this was working with older gtk+ versions.
I guess that is the reason why adwaita use a setting with border-radius=0 for middle buttons, to avoid this brokenness ;)
All i can do is to reduce the horizontal padding for this buttons, which reduce the whole horizontal window size, or adding a setting what you see with adwaita, submarine themes and many others.

Owner

flexiondotorg commented May 20, 2016

In which case, your solution in the Submarine themes is the best I've seen (by a long shot) for this issue. Please proceed with that approach as a solution :-)

Collaborator

raveit65 commented May 20, 2016

smaller buttons
7cfbe6e

Owner

flexiondotorg commented May 20, 2016

I've just tested the latest commit. Perfect :-)

I confirm this issue closed.

Owner

flexiondotorg commented May 24, 2016

@raveit65 Please migrate the fix to Radiant-MATE

Collaborator

raveit65 commented May 24, 2016

done
ae916f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment