-
Notifications
You must be signed in to change notification settings - Fork 38
Scheduling jobs on status page #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach. I found a way to make it a bit simpler. And it should deal with scheduling.
… use job_cache for scheduling jobs Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
…and scheduling jobs on status page Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I like the structure.
Most comments about style & names. Very few about functionality.
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get more ideas while I try this, sorry.
Also found a few small things I want to improve.
Uninstalling highspy was a great way for me to test failing jobs, by the way.
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just two very small comments left for me.
The type annotations do not work on Python3.8: https://github.com/FlexMeasures/flexmeasures/actions/runs/8712586908/job/23899218536?pr=1035 It seems that |
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
You seem to have some import problems |
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
Signed-off-by: Nikolai Rozanov <nickolay.rozanov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
…status Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Description
Extend the current status page - add a simple table on the right of the data connectivity (or beneath) and show the last 10 or 20 jobs, with green or red lights, and with their status/error message available in a tool-tip or on click
Look & Feel
New table on the status page, containing data about latest asset jobs
How to test
Create some jobs for an asset, check they appear on status page of this asset
Further Improvements
.
Related Items
.