[UI] Update the URL start and end of the asset page when the time period is updated#1046
Merged
[UI] Update the URL start and end of the asset page when the time period is updated#1046
start and end of the asset page when the time period is updated#1046Conversation
…e datepicker. Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
nrozanov
approved these changes
Apr 29, 2024
Flix6x
reviewed
May 6, 2024
Comment on lines
+173
to
+175
| // add 1 day to end date as datepicker does not include the end date day | ||
| endDate = endDate.toJSDate(); | ||
| endDate.setDate(endDate.getDate() + 1); |
Contributor
There was a problem hiding this comment.
Possible source of a bug. I just tested this, but when I select 2 days and then refresh, the url indicates a period of 3 days. And when I refresh, it selects those 3 days. (When I refresh again, it does remain at 3 days.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason I don't understand yet, when I refreshed the asset page, the period moved to the latest data instead of keeping the view on the same period. This is why I thought of updating the URL with the start and end dates when an event on the date-picker was caught.
To test this feature, you can go to any asset page and select a time range. The URL should take the values that you selected but the page shouldn't refresh. Following that, you can refresh the page manually to check if the parameters are passed properly.