-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunset API versions 1 and 2 #650
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
… a data source, from v1.1 to v3; also test posting is not allowed for inactive admins Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…rather than fresh_db fixture Signed-off-by: F.N. Claessen <felix@seita.nl>
…of them Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Pull Request Test Coverage Report for Build 4812786450
💛 - Coveralls |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…pectively Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Coverage fell by 9.2%, but the report shows that's mostly because you left the implementations (why?) and in api_utils and validators, where I expect a lot of cleanup later.
I left them in anticipation of supporting blackout tests, and will remove them immediately after release. Technically, I could have left the tests in place until then (and only update the docs and add the blackout test support before release). We could still do it like that, or accept the hit in coverage, which would show longer on Pypi (until the 0.14 release), and only very short on GitHub (until the main branch is updated with the PR that removes the endpoint implementations). |
I'm fine with a short-term low coverage. It's not the most important metric. |
This PR sunsets API versions 1, 1.1, 1.2, 1.3 and 2.0.
* I'm thinking towards supporting FM hosts in running their own blackout tests, by switching a dedicated config setting, then actually removing the endpoints in
flexmeasures==0.14
, which will lead to 404 (Not Found). To be discussed in the next TSC.