Conversation
… report_config schemas. Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
- Renaming BWV and EB to english words. - Simplifying calculation (pandas pipeline). - Adding units to sensors. - Changing units from EUR/kWh to EUR/MWh - Adding assert to check maximum error - deserialize_report_config -> deserialize_reporter_config - Warning when a string starting with `@` is used in the method query or eval. - Making process_pandas_args, process_pandas_kwargs and apply_transformation private methods. Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
- Output type of compute is BeliefDataFrame - Added a global input resolution to schem - ISO datetime and timedeltas - start, end and input_resolution are considered serialized when passed to the method compute - assert to check that result resolution = sensor resolution Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
* No return value Signed-off-by: F.N. Claessen <felix@seita.nl> * typo Signed-off-by: F.N. Claessen <felix@seita.nl> * plural Signed-off-by: F.N. Claessen <felix@seita.nl> * indentation Signed-off-by: F.N. Claessen <felix@seita.nl> * fix return type annotations Signed-off-by: F.N. Claessen <felix@seita.nl> * format docstring example Signed-off-by: F.N. Claessen <felix@seita.nl> * add type annotations Signed-off-by: F.N. Claessen <felix@seita.nl> * predefine instance attributes Signed-off-by: F.N. Claessen <felix@seita.nl> * remove redundant variable Signed-off-by: F.N. Claessen <felix@seita.nl> * grammar Signed-off-by: F.N. Claessen <felix@seita.nl> * support aliases Signed-off-by: F.N. Claessen <felix@seita.nl> * grammar/typos Signed-off-by: F.N. Claessen <felix@seita.nl> * test exact match Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>
…rator classes: Reporter, Scheduler, Forecaster. Signed-off-by: victor <victor@seita.nl>
…-add-reporter-class
…compute` method signature. Signed-off-by: victor <victor@seita.nl>
…e for data generators. Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
…-add-reporter-class
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…-add-reporter-class
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
… value (None) Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
added 8 commits
May 18, 2023 08:14
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
added 3 commits
May 19, 2023 13:00
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
* feat: create show reporter command Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * style: add hint to list reporters Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * style: add module name style: print empty string when the author is missing Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * style: change column order Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * docs: add entry for PR #686 Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * docs: add command flexmeasures show reporters Signed-off-by: Victor Garcia Reolid <victor@seita.nl> --------- Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
…to 642-add-report-cli-command-2
Flix6x
requested changes
May 19, 2023
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
* style: capitalize CSV Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: reporter is no longer a required parameter Signed-off-by: F.N. Claessen <felix@seita.nl> * style: required parameters on top Signed-off-by: F.N. Claessen <felix@seita.nl> * style: fix parameter name in docstring Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: avoid converting dt type Signed-off-by: F.N. Claessen <felix@seita.nl> * feature: add test case with timezone Signed-off-by: F.N. Claessen <felix@seita.nl> * feature: add test case for Pandas structure Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: type annotations Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: use parameter 'end' Signed-off-by: F.N. Claessen <felix@seita.nl> * style: fix type annotation Signed-off-by: F.N. Claessen <felix@seita.nl> * style: justified indentation Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
reviewed
May 19, 2023
added 6 commits
May 19, 2023 17:19
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Contributor
Author
|
Thanks for the review! I'm trying to merge but it's blocked by the condition to not merge with unresolved comments. Checking all the conversations in |
Contributor
Author
Instead, I think it would better if any of @nhoening or @Flix6x merges this to bypass the blockage 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the command flexmeasures add report which allows to create reports (custom calculations defined in classes of type Reporter) and save them to the database or export them to Excel or CSV. It also includes some flags to define the time scope of the report in some predefined ways: --last-hour, --last-day, ...
Closes #642.