remove(api): Versions 1 to 2 are Gone or Not Found#667
Merged
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Contributor
|
For how long do you plan to allow users to return 410 for these routes - one more version? |
Contributor
Author
Yes, one more. So we'd have this sequence:
I could ask in the TSC whether stage 3 is redundant. |
Contributor
|
I think this way to explain our policy would be great on https://flexmeasures.readthedocs.io/en/latest/api/introduction.html#deprecation-and-sunset |
nhoening
reviewed
May 6, 2023
nhoening
approved these changes
May 8, 2023
Contributor
nhoening
left a comment
There was a problem hiding this comment.
I approve, if the discussed addition ti the docs happens: document the steps of an deprecation/sunset/gone cycle
Signed-off-by: F.N. Claessen <felix@seita.nl>
Contributor
Author
|
@nhoening Maybe do a quick check on my documentation changes? |
nhoening
reviewed
May 8, 2023
Contributor
nhoening
left a comment
There was a problem hiding this comment.
I like it, thanks!
- In my opinion, stage 3 is maybe not needed and overcomplicates things a bit. Not sure when and how we should make this decision. We can ask in the TAC. Surely before 0.14.
- Do we already implement support for these stages in the flexmeasures_client?
Contributor
Author
|
Contributor
|
Yes, TSC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove API versions 1.0, 1.1, 1.2, 1.3 and 2.0, while allowing hosts to switch between
HTTP status 410 (Gone)andHTTP status 404 (Not Found)responses.Follow-up issue: remove old data classes.