-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove(api): Versions 1 to 2 are Gone or Not Found #667
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
For how long do you plan to allow users to return 410 for these routes - one more version? |
Yes, one more. So we'd have this sequence:
I could ask in the TSC whether stage 3 is redundant. |
I think this way to explain our policy would be great on https://flexmeasures.readthedocs.io/en/latest/api/introduction.html#deprecation-and-sunset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, if the discussed addition ti the docs happens: document the steps of an deprecation/sunset/gone cycle
Signed-off-by: F.N. Claessen <felix@seita.nl>
@nhoening Maybe do a quick check on my documentation changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, thanks!
- In my opinion, stage 3 is maybe not needed and overcomplicates things a bit. Not sure when and how we should make this decision. We can ask in the TAC. Surely before 0.14.
- Do we already implement support for these stages in the flexmeasures_client?
|
Yes, TSC |
Remove API versions 1.0, 1.1, 1.2, 1.3 and 2.0, while allowing hosts to switch between
HTTP status 410 (Gone)
andHTTP status 404 (Not Found)
responses.Follow-up issue: remove old data classes.