feat(scheduling): Storage scheduler supports losses over time#679
Merged
feat(scheduling): Storage scheduler supports losses over time#679
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…itions Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
4 tasks
nhoening
reviewed
May 18, 2023
Contributor
nhoening
left a comment
nhoening
left a comment
There was a problem hiding this comment.
Very nice PR.
Mostly I have understanding questions, I don't think I caught a problem.
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…er-time # Conflicts: # flexmeasures/data/models/planning/storage.py # flexmeasures/data/models/planning/tests/test_solver.py # flexmeasures/data/schemas/scheduling/storage.py
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
approved these changes
Jun 11, 2023
Contributor
nhoening
left a comment
nhoening
left a comment
There was a problem hiding this comment.
Good work - minor comments on two things only.
Contributor
|
Let's create a follow-up issue for your idea of storage efficiency in units of %/ - I believe that will definitely make this easier to use. |
Contributor
I created #720 |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ma fields Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…er-time # Conflicts: # documentation/changelog.rst
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ports` and `flexmeasures show schedulers` CLI commands Signed-off-by: F.N. Claessen <felix@seita.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #639.
Potential follow-up: support setting a storage efficiency in units of %/<any time unit>, and let the server convert to units of %/<sensor resolution>. Note that this is a compound interest calculation, which is not supported by
pint. ** For example, a storage efficiency of 99 percent per (absolute) day, for scheduling a 1-hour resolution sensor, should be passed to the scheduler as a storage efficiency of$0.99^{1/24}$ .
To do:
validate_storage_constraints#704 (comment)