-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scheduling): Storage scheduler supports losses over time #679
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…itions Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR.
Mostly I have understanding questions, I don't think I caught a problem.
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…er-time # Conflicts: # flexmeasures/data/models/planning/storage.py # flexmeasures/data/models/planning/tests/test_solver.py # flexmeasures/data/schemas/scheduling/storage.py
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work - minor comments on two things only.
Let's create a follow-up issue for your idea of storage efficiency in units of %/ - I believe that will definitely make this easier to use. |
I created #720 |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ma fields Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…er-time # Conflicts: # documentation/changelog.rst
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ports` and `flexmeasures show schedulers` CLI commands Signed-off-by: F.N. Claessen <felix@seita.nl>
Closes #639.
Potential follow-up: support setting a storage efficiency in units of %/<any time unit>, and let the server convert to units of %/<sensor resolution>. Note that this is a compound interest calculation, which is not supported by
pint
. ** For example, a storage efficiency of 99 percent per (absolute) day, for scheduling a 1-hour resolution sensor, should be passed to the scheduler as a storage efficiency of$0.99^{1/24}$ .
To do:
validate_storage_constraints
#704 (comment)