Merged
Conversation
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
Ahmad-Wahid
added
documentation
4 tasks
nhoening
requested changes
May 18, 2023
Contributor
nhoening
left a comment
nhoening
left a comment
There was a problem hiding this comment.
Good work. It made me think of one way to not just show an empty data plot, but something better.
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
Flix6x
requested changes
May 19, 2023
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
Looking good! I'd like one more screenshot at the end, and a little spacing after each image (also the final one at the bottom of the page), which can be accomplished by adding this after each image:
|
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
nhoening
requested changes
May 22, 2023
Signed-off-by: Ahmad Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
nhoening
approved these changes
May 23, 2023
nhoening
requested changes
May 23, 2023
Signed-off-by: Ahmad Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
nhoening
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed
closes #631