Merged
Conversation
added 4 commits
June 1, 2023 12:00
…Error Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Flix6x
requested changes
Jun 9, 2023
Contributor
Flix6x
left a comment
There was a problem hiding this comment.
Very nice to have. Are you sure you don't want this to subclass from PandasReporter instead?
added 9 commits
June 9, 2023 11:12
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Flix6x
requested changes
Jun 9, 2023
added 4 commits
June 9, 2023 17:53
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Base automatically changed from
683-trigger-scheduler-api-endpoint-fails-to-save-the-results-to-the-database-on-subsequent-calls
to
main
June 9, 2023 15:56
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
approved these changes
Jun 10, 2023
Contributor
Flix6x
left a comment
There was a problem hiding this comment.
Looks like this can even be shipped with 0.14. I added a changelog and moved the relevant entry to the Infrastructure / Support category. I also added an experimental disclaimer, because we are planning to still refactor these classes soon (see #662).
Contributor
|
So can this be merged? |
Contributor
|
Yes, but let's give @victorgarcia98 a chance to review my commits first. |
Contributor
Author
|
Thanks! Nice the addition of the experimental warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the class
AggregatorReporterto compute the aggregation (SUMorMEAN) of different sources' into a single one. This reporter allows to add the aggregate energy flows, costs, emissions, etc... of a system in a time period (e.g hourly).Details:
sourcea required parameter inbeliefs_search_configs.weightsfor the different alias. This can be used to convert a consumption (in absolute value) to a negative flow or to convert a current into power (i.emethodcan be set toSUMorMEANto chose the aggregation method.Look & Feel
{ "beliefs_search_configs": [ { "sensor": 1, "source" : 1, "alias" : "PV" }, { "sensor": 1, "source" : 2, "alias" : "CONSUMPTION" } ], "method" : "SUM", "weights" : { "PV" : 1.0, "CONSUMPTION" : -1.0 } }Testing Steps
Test for
MEANandSUMcases in flexmeasures/data/models/reporting/tests/test_aggregator.py.