Skip to content

make fallback scheduler redirect optional#891

Merged
victorgarcia98 merged 4 commits intomainfrom
feature/planning/make-fallback-redirect-optional
Nov 7, 2023
Merged

make fallback scheduler redirect optional#891
victorgarcia98 merged 4 commits intomainfrom
feature/planning/make-fallback-redirect-optional

Conversation

@victorgarcia98
Copy link
Contributor

Description

FLEXMEASURES_FALLBACK_REDIRECT (default: False) config parameter allows control over the redirect mechanism.

Related Items

#846


  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. But now that we decided to avoid a breaking change altogether, I believe we would no longer require the FLEXMEASURES_FALLBACK_REDIRECT setting. That is, for API v3 it would effectively be hardcoded to False.

@Flix6x Flix6x added this to the 0.17.0 milestone Nov 7, 2023
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 requested a review from Flix6x November 7, 2023 10:40
@victorgarcia98 victorgarcia98 merged commit 4453ebf into main Nov 7, 2023
@victorgarcia98 victorgarcia98 deleted the feature/planning/make-fallback-redirect-optional branch November 7, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants