Allow to specify soc-maxima and soc-minima as a range - #899
Merged
Flix6x merged 21 commits intoJan 23, 2024
Conversation
…time windows Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…db fixture Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
marked this pull request as ready for review
January 9, 2024 21:50
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…de them upon initialization Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
victorgarcia98
approved these changes
Jan 22, 2024
victorgarcia98
left a comment
Contributor
There was a problem hiding this comment.
Very nice! 🎆
The only thing is that, perhaps, this should be added to the endpoint docs.
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
deleted the
898-allow-to-specify-soc-maxima-and-soc-minima-as-a-range
branch
January 23, 2024 11:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Non-breaking API change to support less verbose ways of setting the same constraint for a given time window.
Look & Feel
How to test
Further Improvements
P1Dduration over a DST transition takes into account the sensor's IANA timezone [with 4db562d we now ground the nominal durations to the start or end, and I've added tests forP1Mdurations. However, I commented out theP1DandP1Wtest cases, as they require a fundamental fix in isodate.]Related Items
Closes #898.