feature: add usage forecast by victorgarcia98 · Pull Request #906 · FlexMeasures/flexmeasures

victorgarcia98 · 2023-11-22T15:25:39Z

Description

The usage forecast is passed as a new column of the device constraints and later incorporated as a Pyomo parameter. This parameter is used in the device_bounds constraint as an extra component. Multiple components can be defined in the flex-model using the QuantityOrSensor syntax:

Sensor

{
    "usage-forecast" : [
        {"sensor" : 1},
        {"sensor" : 2}
    ]
}

Constant value

{
    "usage-forecast" : [
        "10 kWh",
        "40 kWh",
    ]
}

Further Improvements

Revise/Test definition of capacity_in_mw. For example, using a capacity of 2MW, allowed me to charge 2MWh every 15min block while it should be 500kWh.

TODOs

Add field to API docstring
Add field to documentation
Use field consumption_is_positive. By default, the usage forecast sign interpretation is (+) increase stock level (-) decrease stock level.

Related Items

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

…ensor

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* refactor: fix spelling Signed-off-by: F.N. Claessen <felix@seita.nl> * style: missing type annotation Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: method and variable renaming Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: add test case explanations Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

* refactor: fix spelling Signed-off-by: F.N. Claessen <felix@seita.nl> * style: missing type annotation Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: method and variable renaming Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: add test case explanations Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: separate logic for falling back on a default attribute and applying a maximum capacity limit Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: fill gaps in capacity sensor data using the max_value rather than with the fallback Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: type annotation (see https://docs.python.org/3/library/typing.html#typing.Optional) Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: clearly separate steps of falling back and performing a nanmin Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: simplify and have get_quantity_from_attribute return a Quantity, as its name already suggested Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: switch argument order Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: update docstring Signed-off-by: F.N. Claessen <felix@seita.nl> * style: flake8 Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x

Please remind me: do we still have an unresolved issue in terms of having a test pass that we expected to fail (because of an unsustainable usage forecast)?

Flix6x · 2023-12-04T10:12:14Z

Will you tackle the todos in this PR or as a follow-up?

victorgarcia98 · 2023-12-04T10:47:36Z

Please remind me: do we still have an unresolved issue in terms of having a test pass that we expected to fail (because of an unsustainable usage forecast)?

Yes, other than adding a resampling factor for the sensor, the current test should fail as we are providing the value power_capacity as the energy value to each 15min interval..

…ery-power-capacity-as-sensor Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

… feature/planning/usage-forecast

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x

Awesome. Now it clicks. I only request documentation edits, including the changelog entry of course.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x

Still missing the changelog entry.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Signed-off-by: Victor <victor@seita.nl>

Fix typo (*los componentes*) and swap out some changelog entries between Features and Infrastructure. Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>

Flix6x · 2023-12-19T09:19:52Z

Black is failing after your last merge. Feel free to merge after resolving.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Victor Garcia Reolid added 14 commits November 10, 2023 09:50

add (device) consumption capacity and production capacity as sensors

91c2833

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

convert units of the power limits to the sensor units

63a390f

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add QuantityOrSensor field

8b594b1

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add annotations

4e27c51

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

introduce QuantityorSensor schema

ccbe5d6

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add from __future__ import annotations

6b24016

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Merge branch 'main' into feature/planning/battery-power-capacity-as-s…

4bf8217

…ensor

remove discarded revision

21537dd

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add target unit

661bab6

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

change exception type to FMValidationError

8a5bdba

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add explicity default value

35ada92

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

split into two functions

a9aaf21

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add usage forecast

d826ac8

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add test

4dc808c

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

victorgarcia98 added Scheduling Still Needs Changelog Entry labels Nov 22, 2023

victorgarcia98 self-assigned this Nov 22, 2023

victorgarcia98 requested a review from Flix6x November 22, 2023 15:25

Flix6x requested changes Nov 23, 2023

View reviewed changes

Flix6x and others added 3 commits November 24, 2023 09:54

use resolution to convert energy series to the target event resolution

c8af88f

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

simplify conftest

a878175

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

victorgarcia98 requested a review from Flix6x November 24, 2023 16:46

Flix6x requested changes Dec 4, 2023

View reviewed changes

Victor Garcia Reolid added 3 commits December 12, 2023 11:07

Merge remote-tracking branch 'origin/main' into feature/planning/batt…

01f7fc0

…ery-power-capacity-as-sensor Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

fix test

b677897

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add changelog entry

af65989

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Victor Garcia Reolid added 4 commits December 12, 2023 12:43

Merge branch 'feature/planning/battery-power-capacity-as-sensor' into…

b13394f

… feature/planning/usage-forecast

improve tests and implement consumption_is_positive

4827385

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

add resolution factor to convert from energy units to power units

5e940f2

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

fix test + add new case

06c41ac

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x requested changes Dec 13, 2023

View reviewed changes

Comment thread flexmeasures/data/models/planning/linear_optimization.py Outdated

Comment thread flexmeasures/data/schemas/scheduling/storage.py Outdated

split stock delta into stock gain and stock usage

bf11552

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

victorgarcia98 requested a review from Flix6x December 13, 2023 14:03

Victor Garcia Reolid added 2 commits December 13, 2023 15:09

update changelog

5334df6

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

switch to power units

3743c84

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x requested changes Dec 14, 2023

View reviewed changes

Comment thread flexmeasures/data/models/planning/storage.py Outdated

Comment thread flexmeasures/data/models/planning/tests/conftest.py

victorgarcia98 requested a review from Flix6x December 16, 2023 21:57

improve comments

b642f87

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

Flix6x requested changes Dec 16, 2023

View reviewed changes

Comment thread flexmeasures/data/models/planning/tests/conftest.py Outdated

Flix6x added this to the 0.18.0 milestone Dec 18, 2023

Victor Garcia Reolid added 2 commits December 18, 2023 16:41

add changelog

80ca102

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

merge

ce68106

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

victorgarcia98 requested a review from Flix6x December 18, 2023 15:44

Base automatically changed from feature/planning/battery-power-capacity-as-sensor to main December 19, 2023 08:55

Victor and others added 2 commits December 19, 2023 09:57

Merge branch 'main' into feature/planning/usage-forecast

868b331

Signed-off-by: Victor <victor@seita.nl>

Update changelog.rst

dba8363

Fix typo (*los componentes*) and swap out some changelog entries between Features and Infrastructure. Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>

Flix6x approved these changes Dec 19, 2023

View reviewed changes

Flix6x removed the Still Needs Changelog Entry label Dec 19, 2023

Apply black

ab893ab

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>

victorgarcia98 merged commit 5576b56 into main Dec 19, 2023

victorgarcia98 deleted the feature/planning/usage-forecast branch December 19, 2023 10:23

Flix6x mentioned this pull request Jan 8, 2024

Flex model fields from sensors #955

Closed

Conversation

victorgarcia98 commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Further Improvements

TODOs

Related Items

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Flix6x commented Dec 4, 2023

Uh oh!

victorgarcia98 commented Dec 4, 2023

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Flix6x left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Flix6x commented Dec 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

victorgarcia98 commented Nov 22, 2023 •

edited

Loading