feature(UI): Tables with rows that navigate on click#923
Merged
Conversation
…RL+click and touchscreen actions. Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
approved these changes
Dec 12, 2023
Contributor
nhoening
left a comment
There was a problem hiding this comment.
Works great.
- Worth a changelog entry
- Copying text from the tables isn't possible anymore (only when starting the copying with a click right outside the table, user needs to be crafty). Not sure how annoying that might be.
Signed-off-by: F.N. Claessen <felix@seita.nl>
Contributor
Author
Great catch! |
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
approved these changes
Dec 12, 2023
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<a href>elements that navigate elsewhere.Nameheader is finally aligned with the asset names rather than with their icons.Look & Feel
How to test
Just navigate your local UI. If you find out that this requires a hard refresh in the browser (to reload
flexmeasures.js), please let me know.Use
ngrok http 5000to test on a different (touchscreen) device.