Skip to content

feature(UI): Tables with rows that navigate on click#923

Merged
Flix6x merged 9 commits intomainfrom
feature/table-navigation-ux
Dec 12, 2023
Merged

feature(UI): Tables with rows that navigate on click#923
Flix6x merged 9 commits intomainfrom
feature/table-navigation-ux

Conversation

@Flix6x
Copy link
Copy Markdown
Contributor

@Flix6x Flix6x commented Dec 11, 2023

Description

  • Tables with rows that navigate on click.
  • Hover effect: background and tooltip.
  • Rows may still contain <a href> elements that navigate elsewhere.
  • Handles CTRL+click.
  • Tested for touchscreen actions.
  • Best for last: the Name header is finally aligned with the asset names rather than with their icons.

Look & Feel

Peek 2023-12-11 22-56

How to test

Just navigate your local UI. If you find out that this requires a hard refresh in the browser (to reload flexmeasures.js), please let me know.

Use ngrok http 5000 to test on a different (touchscreen) device.

…RL+click and touchscreen actions.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the UI label Dec 11, 2023
@Flix6x Flix6x added this to the 0.18.0 milestone Dec 11, 2023
@Flix6x Flix6x requested a review from nhoening December 11, 2023 21:58
@Flix6x Flix6x self-assigned this Dec 11, 2023
Copy link
Copy Markdown
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

  • Worth a changelog entry
  • Copying text from the tables isn't possible anymore (only when starting the copying with a click right outside the table, user needs to be crafty). Not sure how annoying that might be.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Copy Markdown
Contributor Author

Flix6x commented Dec 12, 2023

Copying text from the tables isn't possible anymore (only when starting the copying with a click right outside the table, user needs to be crafty). Not sure how annoying that might be.

Great catch!

Signed-off-by: F.N. Claessen <felix@seita.nl>
Copy link
Copy Markdown
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix

Comment thread flexmeasures/ui/static/js/flexmeasures.js
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit c510994 into main Dec 12, 2023
@Flix6x Flix6x deleted the feature/table-navigation-ux branch December 12, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants