New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symmetry betwee PyWidget and Widget #698
Conversation
Wow, thanks for this! You're brave to wander in the most complex parts of Flexx ;) I took a good look and verified that (as far as I can see) popping these values have no consequences elsewhere. I have just a few comments. These are more nitpicky than I'd normally do, but since this code is complex it's worth being extra careful about comments. |
Hi almarklein, the last commit integrates the requested changes on the comments. Flexx is complex but that is what you get when trying to separate GUI from code. Is there a better way? I do think your solution is elegant and brings portability for the created widgets. That is the main driving force behind Flexx. Thank you, |
I meant that these low-level component classes are among the most complex code, but this solution is done very well :) Anyway, thanks! |
Hi almarklein, I would like to push a change to have more symmetry between PyWidget and Widget:
I can do:
But could not do:
Which I found anoying as I'm using server side processing quite a lot and need to switch Widget from one side to the other seamlessly.
I changed the
bokehdemo.py
and inserted a PyWidget within to show the style in action.I have a lot of other things relying on this change so I hope it goes forward one way or another. I hope to submit them at a later point when they get more reliable.
P.S. there is also an optimisation for flask serving within the code (in _flaskserver.py).
Thank you for your time.