Add eslint linting

.eslintrc.js

@@ -0,0 +1,12 @@
+module.exports = {
+
+  extends: 'eslint:recommended',
+
+  env: {
+    node: true
+  },
+
+  rules: {
+  }
+
+};

.travis.yml

@@ -4,6 +4,8 @@ node_js:
 - '4.0'
 - '0.12'
 - '0.10'
+before_script:
+  - npm run lint
 deploy:
   provider: npm
   email: jeremy.ruppel@gmail.com

cli.js

@@ -3,6 +3,8 @@
 // Copyright 2016 Yahoo Inc.
 // Licensed under the terms of the MIT license. Please see LICENSE file in the project root for terms.
 
+/* eslint no-console:"off" */
+
 var http = require('http');
 var path = require('path');
 var PORT = 3000;

hook.sh

@@ -2,6 +2,7 @@
 
 set -ex
 
-npm test
+npm run lint
+npm run test
 
 node package.json

index.js

@@ -32,7 +32,7 @@ module.exports = function (host, opts) {
 
       return Promise.try(function () {
         return require.resolve(file);
-      }).catch(ModuleNotFoundError, function (err) {
+      }).catch(ModuleNotFoundError, function (/* err */) {
         return proxy(req, body, host).then(function (res) {
           return record(res.req, res, file);
         });

lib/proxy.js

@@ -23,7 +23,7 @@ var mods = { 'http:': http, 'https:': https };
  */
 
 module.exports = function proxy(req, body, host) {
-  return new Promise(function (resolve, reject) {
+  return new Promise(function (resolve /*, reject */) {
     var uri  = url.parse(host);
     var mod  = mods[uri.protocol] || http;
     var preq = mod.request({

package.json

@@ -4,6 +4,7 @@
   "description": "Record and playback HTTP responses",
   "main": "index.js",
   "scripts": {
+    "lint": "eslint cli.js index.js lib test",
     "test": "mocha"
   },
   "keywords": [
@@ -23,6 +24,7 @@
   "author": "Jeremy Ruppel",
   "license": "MIT",
   "devDependencies": {
+    "eslint": "^2.9.0",
     "mocha": "~2.3.4",
     "os-tmpdir": "^1.0.1",
     "rimraf": "^2.5.2",

test/buffer.js

@@ -1,6 +1,8 @@
 // Copyright 2016 Yahoo Inc.
 // Licensed under the terms of the MIT license. Please see LICENSE file in the project root for terms.
 
+/* eslint-env mocha */
+
 var subject = require('../lib/buffer');
 var stream = require('stream');
 var assert = require('assert');

test/fixtures/index.js

@@ -15,7 +15,6 @@ function read(file) {
  */
 
 if (semver.gte(process.version, '1.5.0')) {
-  console
   module.exports = read('v1.5.0');
 } else {
   module.exports = read('v0.10.x');

test/helpers/server.js

@@ -17,9 +17,7 @@ module.exports = function createServer(done) {
     res.setHeader('Content-Type', 'text/html');
     res.setHeader('Date', 'Sat, 26 Oct 1985 08:20:00 GMT');
 
-    req.on('data', function (data) {
-      // consume the request body, if any
-    });
+    req.resume(); // consume the request body, if any
 
     req.on('end', function () {
       res.end('OK');

test/proxy.js

@@ -1,6 +1,8 @@
 // Copyright 2016 Yahoo Inc.
 // Licensed under the terms of the MIT license. Please see LICENSE file in the project root for terms.
 
+/* eslint-env mocha */
+
 var subject = require('../lib/proxy');
 var createServer = require('./helpers/server');
 var assert = require('assert');

test/record.js

@@ -1,6 +1,8 @@
 // Copyright 2016 Yahoo Inc.
 // Licensed under the terms of the MIT license. Please see LICENSE file in the project root for terms.
 
+/* eslint-env mocha */
+
 var subject = require('../lib/record');
 var createServer = require('./helpers/server');
 var createTmpdir = require('./helpers/tmpdir');
@@ -32,7 +34,7 @@ describe('record', function () {
   beforeEach(function () {
     req = http.request({
       host: server.addr,
-      port: server.port,
+      port: server.port
     });
     req.setHeader('User-Agent', 'My User Agent/1.0')
     req.setHeader('Connection', 'close');

test/yakbak.js

@@ -1,6 +1,8 @@
 // Copyright 2016 Yahoo Inc.
 // Licensed under the terms of the MIT license. Please see LICENSE file in the project root for terms.
 
+/* eslint-env mocha */
+
 var subject = require('..');
 var createServer = require('./helpers/server');
 var createTmpdir = require('./helpers/tmpdir');