Fix flash when switching top level sections #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🏖 This preview environment has been fully cleaned up. See you next time! |
flybayer
reviewed
Nov 1, 2022
dillondotzip
changed the title
dillondotzip
changed the title
flybayer
reviewed
Nov 3, 2022
Comment on lines
8
to
30
| const getBestGlobMatch = (globs, path) => { | ||
| const match = globs | ||
| .filter(p => minimatch(path, p)) | ||
| .sort((m1, m2) => { | ||
| const d1 = fastLevenshtein.get(m1, path) | ||
| const d2 = fastLevenshtein.get(m2, path) | ||
| return d1 < d2 ? -1 : 1 | ||
| })?.[0] | ||
|
|
||
| if (match === undefined && globs.includes('**/*')) { | ||
| return '**/*' | ||
| } | ||
| return match | ||
| } | ||
|
|
||
| const getTemplateId = (pathname) => { | ||
| const templateMappings = (motifConfig.templates) || {} | ||
| const path = pathname === '/' ? '' : pathname.replace(/^\//, '') | ||
| const matchingGlob = getBestGlobMatch(Object.keys(templateMappings), path) | ||
| if (matchingGlob !== undefined && matchingGlob in templateMappings) { | ||
| return templateMappings[matchingGlob] | ||
| } | ||
| } |
There was a problem hiding this comment.
this should all be moved out of the component
motif-docs/pages/_app.tsx
Outdated
| } | ||
| const Template = dynamic<{children: React.ReactNode, meta: any, path: string, filename: string, files: {}}>(() => | ||
| import('@templates/documentation.mdx').then(mod => (mod as any).Template), | ||
| { ssr: false }, |
flybayer
deleted the
dillon/eng-856-docs-bug-full-page-reloadflash-of-white
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the main documentation template at the top level of the
_app.tsxfile instead of thegetTemplate()function.