-Duse_system_vulkan=enabled fails with Vulkan-Headers >= 1.3.241

[jbeich]

gen_enum_to_str.py (upstream version) currently lacks mesa!21225

In file included from vk_enum_to_str.c:28:
./vk_enum_to_str.h:329:39: error: unknown type name 'VkFaultLevel'
    const char * vk_FaultLevel_to_str(VkFaultLevel input);
                                      ^
./vk_enum_to_str.h:330:47: error: unknown type name 'VkFaultQueryBehavior'
    const char * vk_FaultQueryBehavior_to_str(VkFaultQueryBehavior input);
                                              ^
./vk_enum_to_str.h:331:38: error: unknown type name 'VkFaultType'
    const char * vk_FaultType_to_str(VkFaultType input);
                                     ^
./vk_enum_to_str.h:368:59: error: unknown type name 'VkPipelineCacheValidationVersion'; did you mean 'VkPipelineCacheHeaderVersion'?
    const char * vk_PipelineCacheValidationVersion_to_str(VkPipelineCacheValidationVersion input);
                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                          VkPipelineCacheHeaderVersion
/usr/include/vulkan/vulkan_core.h:1189:3: note: 'VkPipelineCacheHeaderVersion' declared here
} VkPipelineCacheHeaderVersion;
  ^
In file included from vk_enum_to_str.c:28:
./vk_enum_to_str.h:370:49: error: unknown type name 'VkPipelineMatchControl'
    const char * vk_PipelineMatchControl_to_str(VkPipelineMatchControl input);
                                                ^
./vk_enum_to_str.h:391:48: error: unknown type name 'VkSciSyncClientTypeNV'
    const char * vk_SciSyncClientTypeNV_to_str(VkSciSyncClientTypeNV input);
                                               ^
./vk_enum_to_str.h:392:51: error: unknown type name 'VkSciSyncPrimitiveTypeNV'
    const char * vk_SciSyncPrimitiveTypeNV_to_str(VkSciSyncPrimitiveTypeNV input);
                                                  ^
./vk_enum_to_str.h:512:9: error: unknown type name 'PFN_vkGetPhysicalDeviceExternalMemorySciBufPropertiesNV'; did you mean 'PFN_vkGetPhysicalDeviceExternalImageFormatPropertiesNV'?
        PFN_vkGetPhysicalDeviceExternalMemorySciBufPropertiesNV GetPhysicalDeviceExternalMemorySciBufPropertiesNV;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        PFN_vkGetPhysicalDeviceExternalImageFormatPropertiesNV
/usr/include/vulkan/vulkan_core.h:10747:30: note: 'PFN_vkGetPhysicalDeviceExternalImageFormatPropertiesNV' declared here
typedef VkResult (VKAPI_PTR *PFN_vkGetPhysicalDeviceExternalImageFormatPropertiesNV)(VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage, VkImageCreateFlags flags, VkExternalMemoryHandleTypeFlagsNV externalHandleType, VkExternalImageFormatPropertiesNV* pExternalImageFormatProperties);
                             ^
In file included from vk_enum_to_str.c:28:
./vk_enum_to_str.h:531:9: error: unknown type name 'PFN_vkGetPhysicalDeviceRefreshableObjectTypesKHR'; did you mean 'PFN_vkGetPhysicalDevicePresentRectanglesKHR'?
        PFN_vkGetPhysicalDeviceRefreshableObjectTypesKHR GetPhysicalDeviceRefreshableObjectTypesKHR;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        PFN_vkGetPhysicalDevicePresentRectanglesKHR
/usr/include/vulkan/vulkan_core.h:7639:30: note: 'PFN_vkGetPhysicalDevicePresentRectanglesKHR' declared here
typedef VkResult (VKAPI_PTR *PFN_vkGetPhysicalDevicePresentRectanglesKHR)(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, uint32_t* pRectCount, VkRect2D* pRects);
                             ^
In file included from vk_enum_to_str.c:28:
./vk_enum_to_str.h:532:9: error: unknown type name 'PFN_vkGetPhysicalDeviceSciBufAttributesNV'
        PFN_vkGetPhysicalDeviceSciBufAttributesNV GetPhysicalDeviceSciBufAttributesNV;
        ^
./vk_enum_to_str.h:533:9: error: unknown type name 'PFN_vkGetPhysicalDeviceSciSyncAttributesNV'
        PFN_vkGetPhysicalDeviceSciSyncAttributesNV GetPhysicalDeviceSciSyncAttributesNV;
        ^
./vk_enum_to_str.h:697:9: error: unknown type name 'PFN_vkCmdRefreshObjectsKHR'
        PFN_vkCmdRefreshObjectsKHR CmdRefreshObjectsKHR;
        ^
./vk_enum_to_str.h:839:9: error: unknown type name 'PFN_vkCreateSemaphoreSciSyncPoolNV'
        PFN_vkCreateSemaphoreSciSyncPoolNV CreateSemaphoreSciSyncPoolNV;
        ^
./vk_enum_to_str.h:881:9: error: unknown type name 'PFN_vkDestroySemaphoreSciSyncPoolNV'
        PFN_vkDestroySemaphoreSciSyncPoolNV DestroySemaphoreSciSyncPoolNV;
        ^
./vk_enum_to_str.h:911:9: error: unknown type name 'PFN_vkGetCommandPoolMemoryConsumption'
        PFN_vkGetCommandPoolMemoryConsumption GetCommandPoolMemoryConsumption;
        ^
./vk_enum_to_str.h:939:9: error: unknown type name 'PFN_vkGetFaultData'; did you mean 'PFN_vkGetPrivateData'?
        PFN_vkGetFaultData GetFaultData;
        ^~~~~~~~~~~~~~~~~~
        PFN_vkGetPrivateData
/usr/include/vulkan/vulkan_core.h:7203:26: note: 'PFN_vkGetPrivateData' declared here
typedef void (VKAPI_PTR *PFN_vkGetPrivateData)(VkDevice device, VkObjectType objectType, uint64_t objectHandle, VkPrivateDataSlot privateDataSlot, uint64_t* pData);
                         ^
In file included from vk_enum_to_str.c:28:
./vk_enum_to_str.h:941:9: error: unknown type name 'PFN_vkGetFenceSciSyncFenceNV'
        PFN_vkGetFenceSciSyncFenceNV GetFenceSciSyncFenceNV;
        ^
./vk_enum_to_str.h:942:9: error: unknown type name 'PFN_vkGetFenceSciSyncObjNV'
        PFN_vkGetFenceSciSyncObjNV GetFenceSciSyncObjNV;
        ^
./vk_enum_to_str.h:964:9: error: unknown type name 'PFN_vkGetMemorySciBufNV'
        PFN_vkGetMemorySciBufNV GetMemorySciBufNV;
        ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
In file included from ../src/vulkan.cpp:47:
./vk_enum_to_str.h:329:39: error: unknown type name 'VkFaultLevel'
    const char * vk_FaultLevel_to_str(VkFaultLevel input);
                                      ^
./vk_enum_to_str.h:330:47: error: unknown type name 'VkFaultQueryBehavior'
    const char * vk_FaultQueryBehavior_to_str(VkFaultQueryBehavior input);
                                              ^
./vk_enum_to_str.h:331:38: error: unknown type name 'VkFaultType'
    const char * vk_FaultType_to_str(VkFaultType input);
                                     ^
./vk_enum_to_str.h:368:59: error: unknown type name 'VkPipelineCacheValidationVersion'; did you mean 'VkPipelineCacheHeaderVersion'?
    const char * vk_PipelineCacheValidationVersion_to_str(VkPipelineCacheValidationVersion input);
                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                          VkPipelineCacheHeaderVersion
/usr/include/vulkan/vulkan_core.h:1189:3: note: 'VkPipelineCacheHeaderVersion' declared here
} VkPipelineCacheHeaderVersion;
  ^
In file included from ../src/vulkan.cpp:47:
./vk_enum_to_str.h:370:49: error: unknown type name 'VkPipelineMatchControl'
    const char * vk_PipelineMatchControl_to_str(VkPipelineMatchControl input);
                                                ^
./vk_enum_to_str.h:391:48: error: unknown type name 'VkSciSyncClientTypeNV'
    const char * vk_SciSyncClientTypeNV_to_str(VkSciSyncClientTypeNV input);
                                               ^
./vk_enum_to_str.h:392:51: error: unknown type name 'VkSciSyncPrimitiveTypeNV'
    const char * vk_SciSyncPrimitiveTypeNV_to_str(VkSciSyncPrimitiveTypeNV input);
                                                  ^
./vk_enum_to_str.h:512:9: error: unknown type name 'PFN_vkGetPhysicalDeviceExternalMemorySciBufPropertiesNV'; did you mean 'PFN_vkGetPhysicalDeviceExternalImageFormatPropertiesNV'?
        PFN_vkGetPhysicalDeviceExternalMemorySciBufPropertiesNV GetPhysicalDeviceExternalMemorySciBufPropertiesNV;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        PFN_vkGetPhysicalDeviceExternalImageFormatPropertiesNV
/usr/include/vulkan/vulkan_core.h:10747:30: note: 'PFN_vkGetPhysicalDeviceExternalImageFormatPropertiesNV' declared here
typedef VkResult (VKAPI_PTR *PFN_vkGetPhysicalDeviceExternalImageFormatPropertiesNV)(VkPhysicalDevice physicalDevice, VkFormat format, VkImageType type, VkImageTiling tiling, VkImageUsageFlags usage, VkImageCreateFlags flags, VkExternalMemoryHandleTypeFlagsNV externalHandleType, VkExternalImageFormatPropertiesNV* pExternalImageFormatProperties);
                             ^
In file included from ../src/vulkan.cpp:47:
./vk_enum_to_str.h:531:9: error: unknown type name 'PFN_vkGetPhysicalDeviceRefreshableObjectTypesKHR'; did you mean 'PFN_vkGetPhysicalDevicePresentRectanglesKHR'?
        PFN_vkGetPhysicalDeviceRefreshableObjectTypesKHR GetPhysicalDeviceRefreshableObjectTypesKHR;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        PFN_vkGetPhysicalDevicePresentRectanglesKHR
/usr/include/vulkan/vulkan_core.h:7639:30: note: 'PFN_vkGetPhysicalDevicePresentRectanglesKHR' declared here
typedef VkResult (VKAPI_PTR *PFN_vkGetPhysicalDevicePresentRectanglesKHR)(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, uint32_t* pRectCount, VkRect2D* pRects);
                             ^
In file included from ../src/vulkan.cpp:47:
./vk_enum_to_str.h:532:9: error: unknown type name 'PFN_vkGetPhysicalDeviceSciBufAttributesNV'
        PFN_vkGetPhysicalDeviceSciBufAttributesNV GetPhysicalDeviceSciBufAttributesNV;
        ^
./vk_enum_to_str.h:533:9: error: unknown type name 'PFN_vkGetPhysicalDeviceSciSyncAttributesNV'
        PFN_vkGetPhysicalDeviceSciSyncAttributesNV GetPhysicalDeviceSciSyncAttributesNV;
        ^
./vk_enum_to_str.h:697:9: error: unknown type name 'PFN_vkCmdRefreshObjectsKHR'
        PFN_vkCmdRefreshObjectsKHR CmdRefreshObjectsKHR;
        ^
./vk_enum_to_str.h:839:9: error: unknown type name 'PFN_vkCreateSemaphoreSciSyncPoolNV'
        PFN_vkCreateSemaphoreSciSyncPoolNV CreateSemaphoreSciSyncPoolNV;
        ^
./vk_enum_to_str.h:881:9: error: unknown type name 'PFN_vkDestroySemaphoreSciSyncPoolNV'
        PFN_vkDestroySemaphoreSciSyncPoolNV DestroySemaphoreSciSyncPoolNV;
        ^
./vk_enum_to_str.h:911:9: error: unknown type name 'PFN_vkGetCommandPoolMemoryConsumption'
        PFN_vkGetCommandPoolMemoryConsumption GetCommandPoolMemoryConsumption;
        ^
./vk_enum_to_str.h:939:9: error: unknown type name 'PFN_vkGetFaultData'; did you mean 'PFN_vkGetPrivateData'?
        PFN_vkGetFaultData GetFaultData;
        ^~~~~~~~~~~~~~~~~~
        PFN_vkGetPrivateData
/usr/include/vulkan/vulkan_core.h:7203:26: note: 'PFN_vkGetPrivateData' declared here
typedef void (VKAPI_PTR *PFN_vkGetPrivateData)(VkDevice device, VkObjectType objectType, uint64_t objectHandle, VkPrivateDataSlot privateDataSlot, uint64_t* pData);
                         ^
In file included from ../src/vulkan.cpp:47:
./vk_enum_to_str.h:941:9: error: unknown type name 'PFN_vkGetFenceSciSyncFenceNV'
        PFN_vkGetFenceSciSyncFenceNV GetFenceSciSyncFenceNV;
        ^
./vk_enum_to_str.h:942:9: error: unknown type name 'PFN_vkGetFenceSciSyncObjNV'
        PFN_vkGetFenceSciSyncObjNV GetFenceSciSyncObjNV;
        ^
./vk_enum_to_str.h:964:9: error: unknown type name 'PFN_vkGetMemorySciBufNV'
        PFN_vkGetMemorySciBufNV GetMemorySciBufNV;
        ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.

[mazes-80]

Why not just checking system vulkan version instead of formally disabling any use of system vulkan.
I guess mangohud sources will follow and be able to compile with >=1.3.241 at one point.

I maintain a local gentoo package for mangohud. The less we have to rely on subprojects the better it is.

[tim77]

No progress/plans to revert this change and allow build mangohud with recent system version on vulkan-headers?

[evelikov]

There should be zero (practical) difference in the generated code and final binaries, regardless of the version.

Furthermore as the commit mentions - the XML authors have a couple of interesting changes:

• newer XML has fields and functions that we don't use/care about
• have made a hard break meaning that mangohud devs (which is already an extremely scarce resource) would need to maintain effectively two sets of XML generators

I honestly cannot see any benefit from reintroducing the toggle, what am I missing?

[AdelKS]

I honestly cannot see any benefit from reintroducing the toggle, what am I missing?

Distros disable subprojects when bunlding meson packages. So when you force the use of subprojects, packagers need to patch that out so the dependency can again be provided externally.

You can reintroduce the toggle and enforce the version with meson, so packagers can deal with mangohud's vulkan-headers restriction properly

# when using system headers
vulkan_headers_dep = dependency('vulkan-headers', version: '<1.3.241') 

[mazes-80]

Le Sat, 19 Aug 2023 16:55:26 -0700, Adel Kara Slimane ***@***.***> a écrit :

> I honestly cannot see any benefit from reintroducing the toggle, > what am I missing? Distros disable subprojects when bunlding meson packages. So when you force the use of subprojects, packagers need to patch that out so the dependency can again be provided externally.

:thumbs_up:

You can reintroduce the toggle and force the version with meson, so packagers can deal with mangohud's `vulkan-headers` restriction properly ```meson # when using system headers vulkan_headers_dep = dependency('vulkan-headers', version: '<1.3.241') ```

this fixes build system, however it may still conflict with other packages depending on more recent vk-headers.