Skip to content

TAK Server reporting multiple user subscriptions within TAK Server #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CoryFoy opened this issue Aug 7, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@CoryFoy
Copy link
Member

CoryFoy commented Aug 7, 2023

As seen in the below screenshot, when TAK Tracker is connecting to a TAK Server it is registering itself multiple times. In addition, the call sign is not being populated in the server subscriptions

itak-multisubs

@CoryFoy CoryFoy added the bug Something isn't working label Aug 7, 2023
@CoryFoy CoryFoy self-assigned this Aug 7, 2023
@CoryFoy CoryFoy added this to the v1.16 milestone Aug 11, 2023
@CoryFoy
Copy link
Member Author

CoryFoy commented Aug 11, 2023

This is now fixed in the latest TestFlight build (1.16). It was the culmination of two issues:

  1. The TAK Server requires an additional contact and uid node in detail of the CoT to properly identify the user. This commit reworks the XML processing to pull everything into structs and then adds the new nodes in place.
  2. We had a race condition where a connection would be attempting to spin up, but because we weren't connected yet when we'd go to send a CoT message we'd attempt to reconnect, spinning up multiple connections. This is fixed in this commit to ensure we're reusing a single connection and properly tracking the state of its lifecycle.

For issue 1 - though things seem to be working right now, this comment from PyTAK seems to imply we may be missing another use case here. Will have to watch for that in testing.

@CoryFoy CoryFoy closed this as completed Sep 12, 2023
@CoryFoy CoryFoy modified the milestones: v1.16, v1.0 App Store Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant